Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-off hardcoded white colors #11120

Merged
merged 4 commits into from
Oct 23, 2024
Merged

upcoming: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-off hardcoded white colors #11120

merged 4 commits into from
Oct 23, 2024

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Oct 17, 2024 •
edited
Loading

Description 📝

  • Add global colorTokens to the theme and replace one-off hardcoded white color values.
  • Global tokens are theme agnostic and do not require any type merging.
  • A follow-up PR will address the replacement of hardcoded black color values with the token.

Changes 🔄

  • Added global colorTokens to the theme
  • Replaced one-off hardcoded white color values:
    • #fff and #ffff with theme.colorTokens?.Neutrals.White

Target release date 🗓️

N/A

Preview 📷

No visual changes.

How to test 🧪

Verification steps

  • Ensure everything builds properly
  • Ensure No visual changes.
  • Check that all #fff and #ffff values have been replaced.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai added the Design Tokens Laying the groundwork for Design Tokens label Oct 17, 2024
@pmakode-akamai pmakode-akamai self-assigned this Oct 17, 2024
@pmakode-akamai pmakode-akamai changed the title [upcoming]: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-off hardcoded white colors upcoming: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-off hardcoded white colors Oct 17, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review October 21, 2024 04:18
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner October 21, 2024 04:18
@pmakode-akamai pmakode-akamai requested review from hana-akamai and abailly-akamai and removed request for a team October 21, 2024 04:18
@pmakode-akamai pmakode-akamai force-pushed the M3-8755-6700-add-global-colorTokens-to-theme-and-replace-harcoded-white-colors branch from 80616ce to 2bd4ad5 Compare October 23, 2024 10:49
@pmakode-akamai pmakode-akamai added the Approved Multiple approvals and ready to merge! label Oct 23, 2024
@github-actions GitHub Actions
Copy link

Coverage Report: ✅
Base Coverage: 87.01%
Current Coverage: 87.02%

@pmakode-akamai pmakode-akamai merged commit 7b93edc into linode:develop Oct 23, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 23, 2024 •
edited
Loading

Cloud Manager E2E    Run #6719

Run Properties:  status check passed Passed #6719  •  git commit 7b93edc14e: upcoming: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-o...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6719
Run duration 26m 39s
Commit git commit 7b93edc14e: upcoming: [M3-8755, M3-6700] - Add global colorTokens to theme and replace one-o...
Committer Purvesh Makode
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 438
View all changes introduced in this branch ↗︎

@bnussman-akamai bnussman-akamai mentioned this pull request Oct 23, 2024
Merged
This was referenced Oct 25, 2024
Merged
Merged
@bnussman-akamai bnussman-akamai mentioned this pull request Oct 28, 2024
Merged
@pmakode-akamai pmakode-akamai mentioned this pull request Nov 12, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

@abailly-akamai abailly-akamai Awaiting requested review from abailly-akamai abailly-akamai is a code owner automatically assigned from linode/frontend

Assignees

@pmakode-akamai pmakode-akamai

Labels
Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmakode-akamai @hana-akamai @jaalah-akamai