-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 #11241
refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 #11241
Conversation
Coverage Report: ❌ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No styling regressions observed in Cloud ✅
Code review ✅
packages/manager/.changeset/pr-11241-upcoming-features-1731391925729.md
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🎉 445 passing tests on test run #12 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ cloud manager styling
✅ code review
thank you!
Cloud Manager E2E Run #6833
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6833
|
Run duration | 28m 23s |
Commit |
715f5971ee: refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens p...
|
Committer | Purvesh Makode |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
2
|
Skipped |
0
|
Passing |
452
|
View all changes introduced in this branch ↗︎ |
Description 📝
Note
The new colors are based on design tokens and have been selected to closely match the existing colors.
Related PRs:
Changes 🔄
pink
withtheme.tokens.color.Pink[40]
(#f3c6e2)#e3e5e8
withtheme.tokens.color.Neutrals[20]
and its equivalent color (#E5E5EA) inmonitor-disabled.svg
#2e3238
withtheme.tokens.color.Neutrals[100]
(#343438)#c9c7c7
withtheme.tokens.color.Neutrals[40]
(#c2c2ca)#606469
withtheme.tokens.color.Neutrals[70]
(#696970)#555
withtheme.tokens.color.Neutrals[80]
(#515157)#c9cacb
withtheme.tokens.color.Neutrals[40]
orColor.Neutrals[40]
and its equivalent color (#c2c2ca) intoggleOff.svg
#9ea4ae
withtheme.tokens.color.Neutrals[50]
(#a3a3ab)#cdd0d5
withtheme.tokens.color.Neutrals[30]
(#d6d6dd)#ccc
withtheme.tokens.color.Neutrals[40]
(#c2c2ca)#222
withtheme.tokens.color.Neutrals.Black
(#232326)#f4f4f4
withtheme.tokens.color.Neutrals[5]
or equivalent (#f7f7fa)Target release date 🗓️
N/A
Preview 📷
How to test 🧪
As an Author I have considered 🤔
Check all that apply