Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 #11241

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Nov 12, 2024

Description 📝

  • Replace one-off hardcoded color values with color tokens - Part 3
  • colorTokens are global tokens, and they are theme-agnostic.

Note

The new colors are based on design tokens and have been selected to closely match the existing colors.

Related PRs:

Changes 🔄

  • Replaced pink with theme.tokens.color.Pink[40] (#f3c6e2)
  • Replaced #e3e5e8 with theme.tokens.color.Neutrals[20] and its equivalent color (#E5E5EA) in monitor-disabled.svg
  • Replaced #2e3238 with theme.tokens.color.Neutrals[100] (#343438)
  • Replaced #c9c7c7 with theme.tokens.color.Neutrals[40] (#c2c2ca)
  • Replaced #606469 with theme.tokens.color.Neutrals[70] (#696970)
  • Replaced #555 with theme.tokens.color.Neutrals[80] (#515157)
  • Replaced #c9cacb with theme.tokens.color.Neutrals[40] or Color.Neutrals[40] and its equivalent color (#c2c2ca) in toggleOff.svg
  • Replaced #9ea4ae with theme.tokens.color.Neutrals[50] (#a3a3ab)
  • Replaced #cdd0d5 with theme.tokens.color.Neutrals[30] (#d6d6dd)
  • Replaced #ccc with theme.tokens.color.Neutrals[40] (#c2c2ca)
  • Replaced #222 with theme.tokens.color.Neutrals.Black (#232326)
  • Replaced #f4f4f4 with theme.tokens.color.Neutrals[5] or equivalent (#f7f7fa)

Target release date 🗓️

N/A

Preview 📷

  • Slight change in the colors.
  • The new colors are based on design tokens and have been selected to closely match the existing colors.

How to test 🧪

  • Ensure everything builds properly
  • Use colorpicker to differentiate between the two colors

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai added the Design Tokens Laying the groundwork for Design Tokens label Nov 12, 2024
@pmakode-akamai pmakode-akamai self-assigned this Nov 12, 2024
@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-6700] - Replace hardcoded color values with color tokens pt3 upcoming: [M3-6700] - Replace one-off hardcoded color values with color tokens pt3 Nov 12, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 12, 2024 09:12
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner November 12, 2024 09:12
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team November 12, 2024 09:12
Copy link

github-actions bot commented Nov 12, 2024

Coverage Report:
Base Coverage: 87.32%
Current Coverage: 87.3%

@dwiley-akamai dwiley-akamai changed the title upcoming: [M3-6700] - Replace one-off hardcoded color values with color tokens pt3 upcoming: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 Nov 13, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No styling regressions observed in Cloud ✅
Code review ✅

@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens pt3 Nov 15, 2024
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Nov 15, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 445 passing tests on test run #12 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing445 Passing2 Skipped91m 52s

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ cloud manager styling
✅ code review

thank you!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 15, 2024
@pmakode-akamai pmakode-akamai merged commit 715f597 into linode:develop Nov 18, 2024
23 checks passed
Copy link

cypress bot commented Nov 18, 2024

Cloud Manager E2E    Run #6833

Run Properties:  status check passed Passed #6833  •  git commit 715f5971ee: refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens p...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6833
Run duration 28m 23s
Commit git commit 715f5971ee: refactor: [M3-8898] - Replace one-off hardcoded color values with color tokens p...
Committer Purvesh Makode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants