Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webengage #555

Merged
merged 2 commits into from
Oct 19, 2016
Merged

Webengage #555

merged 2 commits into from
Oct 19, 2016

Conversation

abemassry
Copy link
Contributor

@abemassry abemassry commented Oct 19, 2016

adding webengage for feedback

Closes #547

@@ -13,6 +13,7 @@ _.plugins = [
'ENV_APP_ROOT': JSON.stringify(process.env.APP_ROOT),
'ENV_API_ROOT': JSON.stringify(process.env.API_ROOT),
'ENV_LOGIN_ROOT': JSON.stringify(process.env.LOGIN_ROOT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a ,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@abemassry abemassry force-pushed the webengage branch 5 times, most recently from 19754e3 to 5cc8c6a Compare October 19, 2016 20:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.645% when pulling d6de409 on abemassry:webengage into 1a748aa on linode:master.

@eatonphil eatonphil merged commit 2159592 into linode:master Oct 19, 2016
@abemassry abemassry deleted the webengage branch December 2, 2016 20:37
pmakode-akamai added a commit to pmakode-akamai/manager that referenced this pull request Nov 11, 2024
pmakode-akamai added a commit to pmakode-akamai/manager that referenced this pull request Nov 12, 2024
pmakode-akamai added a commit that referenced this pull request Nov 18, 2024
…or tokens pt3 (#11241)

* Replace one-off hardcoded color values with color tokens pt3

* Replace #c9c7c7 with theme.tokens.color.Neutrals[40]

* Replace #606469 with theme.tokens.color.Neutrals[70]

* Replace #555 with theme.tokens.color.Neutrals[80]

* Replace #c9cacb with theme.tokens.color.Neutrals[40] or equivalent

* Added changeset: Replace one-off hardcoded color values with color tokens pt3

* Replace '#9ea4ae' with theme.tokens.color.Neutrals[50]

* Replace `#cdd0d5` with `theme.tokens.color.Neutrals[30]`

* Replace `#ccc` with `theme.tokens.color.Neutrals[40]`

* Replace `#222` with `theme.tokens.color.Neutrals.Black`

* Replace `#f4f4f4` with `theme.tokens.color.Neutrals[5]` or equivalent

* Update changeset file

* Remove color instances from Divider component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants