-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webengage #555
Merged
Merged
Webengage #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na3d
reviewed
Oct 19, 2016
@@ -13,6 +13,7 @@ _.plugins = [ | |||
'ENV_APP_ROOT': JSON.stringify(process.env.APP_ROOT), | |||
'ENV_API_ROOT': JSON.stringify(process.env.API_ROOT), | |||
'ENV_LOGIN_ROOT': JSON.stringify(process.env.LOGIN_ROOT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a ,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
abemassry
force-pushed
the
webengage
branch
5 times, most recently
from
October 19, 2016 20:03
19754e3
to
5cc8c6a
Compare
eatonphil
approved these changes
Oct 19, 2016
pmakode-akamai
added a commit
to pmakode-akamai/manager
that referenced
this pull request
Nov 11, 2024
pmakode-akamai
added a commit
to pmakode-akamai/manager
that referenced
this pull request
Nov 12, 2024
pmakode-akamai
added a commit
that referenced
this pull request
Nov 18, 2024
…or tokens pt3 (#11241) * Replace one-off hardcoded color values with color tokens pt3 * Replace #c9c7c7 with theme.tokens.color.Neutrals[40] * Replace #606469 with theme.tokens.color.Neutrals[70] * Replace #555 with theme.tokens.color.Neutrals[80] * Replace #c9cacb with theme.tokens.color.Neutrals[40] or equivalent * Added changeset: Replace one-off hardcoded color values with color tokens pt3 * Replace '#9ea4ae' with theme.tokens.color.Neutrals[50] * Replace `#cdd0d5` with `theme.tokens.color.Neutrals[30]` * Replace `#ccc` with `theme.tokens.color.Neutrals[40]` * Replace `#222` with `theme.tokens.color.Neutrals.Black` * Replace `#f4f4f4` with `theme.tokens.color.Neutrals[5]` or equivalent * Update changeset file * Remove color instances from Divider component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding webengage for feedback
Closes #547