Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: LKE ACL copy and placeholder updates #11173

Merged

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 28, 2024

Description 📝

Some small design changes/feedback for LKE ACL after some additional testing

skipping a changeset since LKE ACL isn't in prod yet

Changes 🔄

  • update copy in Create Cluster cc @mjac0bs
  • Remove placeholders from IP fields
  • Change notice position in drawer for LKE clusters without ACL pre-'installed'
  • Update corresponding tests
    NOTE: when this gets merged back to develop, lke-create.spec.ts tests will fail >> will update that after!

Target release date 🗓️

10/28 🙏

Preview 📷

Before After
image image image image

How to test 🧪

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"
  • confirm copy updated, confirm no more placeholders for IP fields, confirm notice position changed on the install flow ^

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai added the LKE Related to Linode Kubernetes Engine offerings label Oct 28, 2024
@coliu-akamai coliu-akamai self-assigned this Oct 28, 2024
@coliu-akamai coliu-akamai requested review from a team as code owners October 28, 2024 14:46
@coliu-akamai coliu-akamai requested review from AzureLatte, bnussman-akamai and jaalah-akamai and removed request for a team October 28, 2024 14:46
@coliu-akamai coliu-akamai changed the title change - LKE ACL copy and placeholder updates change: LKE ACL copy and placeholder updates Oct 28, 2024
Copy link

Coverage Report:
Base Coverage: 86.99%
Current Coverage: 86.99%

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Oct 28, 2024
@bnussman-akamai bnussman-akamai merged commit 568be11 into linode:release-v1.131.0 Oct 28, 2024
23 checks passed
@coliu-akamai coliu-akamai deleted the small-acl-changes branch November 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! LKE Related to Linode Kubernetes Engine offerings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants