test: [M3-8776] - Fix lke-create tests and create unit tests for LKE ACL #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
added
Testing
LKE
coliu-akamai
requested review from
cliu-akamai,
carrillo-erik,
abailly-akamai,
mjac0bs and
bnussman-akamai
and removed request for
a team
…ix lke-create.spec.ts failures
bnussman-akamai
approved these changes
Oct 28, 2024
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks @coliu-akamai - this was all passing locally for me and appreciate the clean up! I restarted the CI test current branch job because it failed and my guess it that it was existing flake.
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 29s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes test failures for lke-create.spec.ts and takes care of [m3-8776] while at it
Changes 🔄
Target release date 🗓️
11/12
How to test 🧪
As an Author I have considered 🤔
Check all that apply