test: [M3-8810] - Fix DBaaS failures when v2 feature flag is enabled #11190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
requested review from
dwiley-akamai and
harsh-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 30, 2024
12 tasks
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 27m 44s |
| Commit |
|
| Committer | jdamore-linode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We've been seeing DBaaS resize test failures on every test run as a result of a DBaaS feature flag change earlier today. Since this feature flag will be enabled more often as testing continues, this PR seeks to make the test pass regardless of the value of the flag.
It does this by removing an assertion that's only relevant when the feature flag is disabled. The DBaaS team is invited to refactor these tests if this assertion is crucial, but otherwise we'll proceed with this as a quick fix.
Changes 🔄
Remove assertion to allow DBaaS resize tests to pass regardless of state of v2 feature flag.
How to test 🧪
We can rely on CI for this, but you're welcome to run the test locally as well.
As an Author I have considered 🤔
Check all that apply