Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8760] - Improve stability of Linode end-to-end tests #11350

Conversation

jdamore-linode
Copy link
Contributor

@jdamore-linode jdamore-linode commented Dec 2, 2024

Description 📝

Various improvements to our Linode end-to-end tests to reduce flakiness. Mostly revolves around increasing the Linode create timeout and ensuring the timeout is used in the tests.

Changes 🔄

  • Increase Linode create timeout to 5 minutes
  • Use the timeout value when creating Linodes end-to-end

Target release date 🗓️

N/A

How to test 🧪

(Pending)

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jdamore-linode jdamore-linode self-assigned this Dec 2, 2024
@jdamore-linode jdamore-linode marked this pull request as ready for review December 10, 2024 14:54
@jdamore-linode jdamore-linode requested a review from a team as a code owner December 10, 2024 14:54
@jdamore-linode jdamore-linode requested review from AzureLatte and removed request for a team December 10, 2024 14:54
@jdamore-linode jdamore-linode requested a review from a team as a code owner December 10, 2024 14:55
@jdamore-linode jdamore-linode requested review from carrillo-erik and coliu-akamai and removed request for a team December 10, 2024 14:55
@jdamore-linode jdamore-linode changed the title test: [various] - Improve stability of Linode end-to-end tests test: [M3-8760] - Improve stability of Linode end-to-end tests Dec 10, 2024
Copy link

github-actions bot commented Dec 10, 2024

Coverage Report:
Base Coverage: 86.78%
Current Coverage: 86.78%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests pass

Do we need use the same timeout for rescue-linode.spec.ts and update-linode-labels.spec.ts?

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 12, 2024
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 12, 2024
@jdamore-linode
Copy link
Contributor Author

jdamore-linode commented Dec 12, 2024

✅ Tests pass

Do we need use the same timeout for rescue-linode.spec.ts and update-linode-labels.spec.ts?

We probably should! Not sure why I didn't tackle them to begin with, but just pushed that. Thanks @jaalah-akamai!

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 464 passing tests on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing464 Passing2 Skipped115m 29s

@jdamore-linode jdamore-linode merged commit 0fd6108 into linode:develop Dec 13, 2024
23 checks passed
Copy link

cypress bot commented Dec 13, 2024

Cloud Manager E2E    Run #6966

Run Properties:  status check passed Passed #6966  •  git commit 0fd6108529: test: [M3-8760] - Improve stability of Linode end-to-end tests (#11350)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6966
Run duration 26m 43s
Commit git commit 0fd6108529: test: [M3-8760] - Improve stability of Linode end-to-end tests (#11350)
Committer jdamore-linode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants