Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8760] - Improve stability of Linode end-to-end tests #11350

Merged
merged 17 commits into from
Dec 13, 2024
Merged

test: [M3-8760] - Improve stability of Linode end-to-end tests #11350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c669992
Wait for Linode Create timeout when provisioning and booting new Linodes
jdamore-linode Nov 21, 2024
bd56bc4
Merge branch 'develop' into M3-8760-linode-e2e-increase-timeouts
jdamore-linode Nov 25, 2024
542e88c
Fix small test flaw involving unexpected mock event timestamp
jdamore-linode Nov 25, 2024
28d6b29
Merge branch 'develop' into M3-8760-linode-e2e-increase-timeouts
jdamore-linode Nov 27, 2024
b9b0d09
Use `LINODE_CREATE_TIMEOUT` as default timeout for `cy.defer`, `creat…
jdamore-linode Nov 27, 2024
fb74588
Fix rebuild failures by scrolling to search field before asserting it…
jdamore-linode Dec 2, 2024
75b9477
Use Linode create timeout when waiting for "RUNNING" indicator
jdamore-linode Dec 2, 2024
636fbf5
Use default Linode create timeout when polling Linode status
jdamore-linode Dec 2, 2024
5fe3b76
Refactor Linode resize tests, use Linode timeout when waiting to resize
jdamore-linode Dec 2, 2024
cff0e8a
Increase Linode create timeout to 5 mins
jdamore-linode Dec 2, 2024
acc0b4c
Merge branch 'develop' into M3-8760-linode-e2e-increase-timeouts
jdamore-linode Dec 2, 2024
03e6153
Increase timeouts for more Linode tests
jdamore-linode Dec 2, 2024
c27d6df
Merge branch 'develop' into M3-8760-linode-e2e-increase-timeouts
jdamore-linode Dec 10, 2024
c079d3b
Revert Linode clone changes in favor of M3-8804
jdamore-linode Dec 10, 2024
5b9e917
Added changeset: Improve Linode end-to-end test stability by increasi…
jdamore-linode Dec 10, 2024
c455542
Remove rebuild `scrollIntoView` call in favor of M3-8768
jdamore-linode Dec 10, 2024
146112d
Increase Linode create timeout for rescue and label update tests
jdamore-linode Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11350-tests-1733842479277.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tests
---

Improve Linode end-to-end test stability by increasing timeouts ([#11350](https://github.com/linode/manager/pull/11350))
3 changes: 1 addition & 2 deletions packages/manager/cypress/e2e/core/images/machine-image-upload.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,11 @@ describe('machine image', () => {
const label = randomLabel();
const status = 'failed';
const message = 'Upload window expired';
const expiredDate = DateTime.local().minus({ days: 1 }).toISO();
uploadImage(label);
cy.wait('@imageUpload').then((xhr) => {
const imageId = xhr.response?.body.image.id;
assertProcessing(label, imageId);
eventIntercept(label, imageId, status, message, expiredDate);
eventIntercept(label, imageId, status, message);
cy.wait('@getEvent');
assertFailed(label, imageId, message);
});
Expand Down
9 changes: 7 additions & 2 deletions packages/manager/cypress/e2e/core/linodes/backup-linode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import { dcPricingMockLinodeTypesForBackups } from 'support/constants/dc-specifi
import { chooseRegion } from 'support/util/regions';
import { expectManagedDisabled } from 'support/api/managed';
import { createTestLinode } from 'support/util/linodes';
import { LINODE_CREATE_TIMEOUT } from 'support/constants/linodes';

const BackupsCancellationNote =
'Once backups for this Linode have been canceled, you cannot re-enable them for 24 hours.';
Expand Down Expand Up @@ -76,7 +77,9 @@ describe('linode backups', () => {
cy.wait('@getLinode');

// Wait for Linode to finish provisioning.
cy.findByText('OFFLINE').should('be.visible');
cy.findByText('OFFLINE', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

// Confirm that enable backups prompt is shown.
cy.contains(
Expand Down Expand Up @@ -184,7 +187,9 @@ describe('linode backups', () => {
cy.wait('@getLinode');

// Wait for the Linode to finish provisioning.
cy.findByText('OFFLINE').should('be.visible');
cy.findByText('OFFLINE', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

cy.findByText('Manual Snapshot')
.should('be.visible')
Expand Down
13 changes: 10 additions & 3 deletions packages/manager/cypress/e2e/core/linodes/rebuild-linode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
mockRebuildLinodeError,
} from 'support/intercepts/linodes';
import { createTestLinode } from 'support/util/linodes';
import { LINODE_CREATE_TIMEOUT } from 'support/constants/linodes';

/**
* Creates a Linode and StackScript.
Expand Down Expand Up @@ -126,7 +127,9 @@ describe('rebuild linode', () => {
interceptRebuildLinode(linode.id).as('linodeRebuild');

cy.visitWithLogin(`/linodes/${linode.id}`);
cy.findByText('RUNNING').should('be.visible');
cy.findByText('RUNNING', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

openRebuildDialog(linode.label);
findRebuildDialog(linode.label).within(() => {
Expand Down Expand Up @@ -182,7 +185,9 @@ describe('rebuild linode', () => {
interceptRebuildLinode(linode.id).as('linodeRebuild');
interceptGetStackScripts().as('getStackScripts');
cy.visitWithLogin(`/linodes/${linode.id}`);
cy.findByText('RUNNING').should('be.visible');
cy.findByText('RUNNING', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

openRebuildDialog(linode.label);
findRebuildDialog(linode.label).within(() => {
Expand Down Expand Up @@ -255,7 +260,9 @@ describe('rebuild linode', () => {
).then(([stackScript, linode]) => {
interceptRebuildLinode(linode.id).as('linodeRebuild');
cy.visitWithLogin(`/linodes/${linode.id}`);
cy.findByText('RUNNING').should('be.visible');
cy.findByText('RUNNING', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

openRebuildDialog(linode.label);
findRebuildDialog(linode.label).within(() => {
Expand Down
5 changes: 4 additions & 1 deletion packages/manager/cypress/e2e/core/linodes/rescue-linode.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
} from 'support/intercepts/linodes';
import { ui } from 'support/ui';
import { cleanUp } from 'support/util/cleanup';
import { LINODE_CREATE_TIMEOUT } from 'support/constants/linodes';
import { createTestLinode } from 'support/util/linodes';
import { randomLabel } from 'support/util/random';
import { chooseRegion } from 'support/util/regions';
Expand Down Expand Up @@ -63,7 +64,9 @@ describe('Rescue Linodes', () => {
cy.wait('@getLinode');

// Wait for Linode to boot.
cy.findByText('RUNNING').should('be.visible');
cy.findByText('RUNNING', { timeout: LINODE_CREATE_TIMEOUT }).should(
'be.visible'
);

// Open rescue dialog using action menu..
ui.actionMenu
Expand Down
Loading
Loading