fix: [M3-6430] - Event entities should only be linked for true labels #9003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
approved these changes
Apr 17, 2023
cpathipa
approved these changes
Apr 17, 2023
| @@ -87,4 +88,52 @@ describe('Event message generation', () => { | |||
| ).not.toMatch('booted with'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('apply linking to labels', () => { | |||
There was a problem hiding this comment.
Thank you for adding test coverage!
Comment on lines
94
to
98
| const mockEvent = { | ||
| action: 'create', | ||
| entity: null, | ||
| secondary_entity: null, | ||
| }; |
There was a problem hiding this comment.
Can we use the eventFactory from packages/manager/src/factories/events.ts to create the mockEvents so we don't have to type cast?
What can we do to avoid message as any?
There was a problem hiding this comment.
message is a required prop, which can't be null which is why it's casted. not particularly important to be very strict with the type here. That being said I refactored some of the unit to use the factory for events 👍
bnussman-akamai
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Issue
Our
applyLinkingscript was attempting to replace entity labels within backticks, resulting in plaintext HTML in our event list. It was also not linking the true entity because the replace instance wasn't using a global modifier in case two instances of the label were matching.Solution
Modified the replace to only target true labels and leave alone strings surrounded by backticks. Also added a test for the
applyLinkingfunctionPreview 📷
Before
After
How to test 🧪