fix: [M3-6430] - Event entities should only be linked for true labels

CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 ### Fixed:
 - Typesafety of the `<Select />` component #8986
 - Clear the Kubernetes Delete Dialog when it is re-opened #9000
+- Event entities should only be linked for true labels
 
 ### Tech Stories:
 - MUIv5 Migration - Components > TagsInput, TagsPanel #8995

packages/manager/src/eventMessageGenerator.test.ts

@@ -4,6 +4,7 @@ import getEventMessage, {
   eventMessageCreators,
   safeSecondaryEntityLabel,
 } from './eventMessageGenerator';
+import { applyLinking } from './eventMessageGenerator';
 
 beforeEach(() => {
   jest.spyOn(console, 'error').mockImplementation(() => {});
@@ -87,4 +88,52 @@ describe('Event message generation', () => {
       ).not.toMatch('booted with');
     });
   });
+
+  describe('apply linking to labels', () => {
+    it('should return empty string if message is falsy', () => {
+      const mockEvent = {
+        action: 'create',
+        entity: null,
+        secondary_entity: null,
+      };
+      const message = null;
+      const result = applyLinking(mockEvent as Event, message as any);
+
+      expect(result).toEqual('');
+    });
+
+    it('should replace entity label with link if entity and link exist', () => {
+      const entity = { id: '123', label: 'foo', type: 'linode' };
+      const mockEvent = { action: 'create', entity, secondary_entity: null };
+      const message = 'created entity foo';
+      const link = '/linodes/123';
+      const result = applyLinking(mockEvent as any, message);
+
+      expect(result).toEqual(`created entity <a href="${link}">foo</a> `);
+    });
+
+    it('should replace secondary entity label with link if entity and link exist', () => {
+      jest.clearAllMocks();
+
+      const entity = { id: '123', label: 'foo', type: 'linode' };
+      const secondary_entity = { id: '456', label: 'bar' };
+      const mockEvent = { action: 'create', entity, secondary_entity };
+      const message = 'created secondary_entity for foo';
+      const link = '/linodes/123';
+      const result = applyLinking(mockEvent as any, message);
+
+      expect(result).toEqual(
+        `created secondary_entity for <a href="${link}">foo</a> `
+      );
+    });
+
+    it('should not replace entity label if label is inside backticks', () => {
+      const entity = { id: '123', label: 'foo' };
+      const mockEvent = { action: 'create', entity, secondary_entity: null };
+      const message = 'created `foo`';
+      const result = applyLinking(mockEvent as any, message);
+
+      expect(result).toEqual('created `foo`');
+    });
+  });
 });

packages/manager/src/eventMessageGenerator.ts

@@ -846,7 +846,7 @@ function applyBolding(event: Event, message: string) {
   return newMessage;
 }
 
-function applyLinking(event: Event, message: string) {
+export function applyLinking(event: Event, message: string) {
   if (!message) {
     return '';
   }
@@ -857,14 +857,19 @@ function applyLinking(event: Event, message: string) {
     event.secondary_entity,
     false
   );
+
   let newMessage = message;
 
   if (event.entity && entityLinkTarget) {
+    const label = event.entity.label;
+    const nonTickedLabels = new RegExp(`(?<!\`)${label}`, 'g');
+
     newMessage = newMessage.replace(
-      event.entity.label,
-      `<a href="${entityLinkTarget}">${event.entity.label}</a>`
+      nonTickedLabels,
+      `<a href="${entityLinkTarget}">${label}</a> `
     );
   }
+
   if (event.secondary_entity && secondaryEntityLinkTarget) {
     newMessage = newMessage.replace(
       event.secondary_entity.label,