Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-6965] - Update api-v4 and mocks for DC-specific pricing #9586

Merged
merged 6 commits into from
Aug 24, 2023
Merged

feat: [M3-6965] - Update api-v4 and mocks for DC-specific pricing #9586

merged 6 commits into from
Aug 24, 2023

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Aug 23, 2023 •
edited
Loading

Description 📝

Updates api-v4 types and mocks for expected DC-specific pricing changes to API responses.

Note: #9572 includes the api-v4 updates for adding region_prices to a Linode; I'll pull those changes in once that PR is merged.

How to test 🧪

  1. How to setup test environment?
  • Turn the Mock Service Worker on.
  • Ensure the DC-Specific Pricing flag is on.
  1. How to verify changes?
  • With mocks on, go to the following pages and confirm using the browser dev tools' network tab that the API responses returned for the following endpoints have the data you'd expect based on the example payload in the API spec. The API spec is linked in this ticket or the epic.:
    • Linode Create: confirm backups has added region_prices list for the linode/types endpoint
    • MNTP dialog: confirm region_transfers has been added to the account/transfers endpoint
    • Invoice Details (go to http://localhost:3000/account/billing/ and click on an invoice): confirm region has been added for the account/invoices/:id/items endpoint

@mjac0bs mjac0bs added @linode/api-v4 Changes are made to the @linode/api-v4 package DC-Specific Pricing labels Aug 23, 2023
@mjac0bs mjac0bs self-assigned this Aug 23, 2023
@mjac0bs mjac0bs force-pushed the M3-6965-dc-specific-pricing-api-updates branch from 298abe1 to a3124c3 Compare August 23, 2023 15:59
cpathipa
cpathipa approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 24, 2023
bnussman-akamai
bnussman-akamai approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 24, 2023
@mjac0bs mjac0bs merged commit 35286bd into linode:develop Aug 24, 2023
This was referenced Sep 5, 2023
Merged
Merged
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
@mjac0bs @corya-akamai
feat: [M3-6965] - Update api-v4 and mocks for DC-specific pricing (li…
06cde4e 
…node#9586)

* Update api-v4 and queries

* Update factories

* Add mock invoice details page

* Mock Linode Details Backups tab empty state

* Add changesets

* Add a mock linode in a price increase region
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpathipa cpathipa cpathipa approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai Awaiting requested review from abailly-akamai

Assignees

@mjac0bs mjac0bs

Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing @linode/api-v4 Changes are made to the @linode/api-v4 package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjac0bs @bnussman-akamai @cpathipa