Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-6969] - Add DC Specific Pricing Notices and Docs Links #9572

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Aug 21, 2023

Description 📝

  • Adds Notices and Docs Links to Linode Create flow and NodeBalancer create flow.

Major Changes 🔄

  • Adds general DC specific notice to Linode Create flow and NodeBalancer create flow ⚠️
  • Adds special notice to Linode Clone flow for cloning to region with new price 💵

Preview 📷

NodeBalancer Create

Screenshot 2023-08-21 at 1 42 42 PM

Linode Create

Screenshot 2023-08-21 at 1 43 02 PM

NodeBalancer Clone (to region with different price 💵)

Screenshot 2023-08-21 at 1 48 08 PM

Kubernetes Create

Screenshot 2023-08-21 at 4 10 26 PM

How to test 🧪

  • Test the flows described above with the feature flag on and off
  • You probably will need to use the MSW to test the special clone warning

@bnussman-akamai bnussman-akamai self-assigned this Aug 21, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approving pending a couple improvements

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 23, 2023
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notices and docs links are looking good -- we'll just want to make sure that we address the console warning happening on the Box component.

packages/manager/src/factories/linodes.ts Outdated Show resolved Hide resolved
@@ -303,6 +308,7 @@ export interface LinodeType extends BaseType {
network_out: number;
gpus: number;
price: PriceObject;
region_prices: RegionPriceObject[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not duplicate your changes, I'm going to leave this out of M3-6965 and pull your changes in once this is merged.

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 23, 2023
@bnussman-akamai bnussman-akamai merged commit b5b4ad1 into linode:develop Aug 23, 2023
coliu-akamai pushed a commit to coliu-akamai/manager that referenced this pull request Aug 23, 2023
…ode#9572)

* inital docs and notices

* wip

* clean up and unit test helper functions

* add banner to lke create

* dial in styles and behavior

* Added changeset: Add DC Specific Pricing Notices and Docs Links

* feedback

* fix linode clone e2e test

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
…ode#9572)

* inital docs and notices

* wip

* clean up and unit test helper functions

* add banner to lke create

* dial in styles and behavior

* Added changeset: Add DC Specific Pricing Notices and Docs Links

* feedback

* fix linode clone e2e test

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants