-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6969] - Add DC Specific Pricing Notices and Docs Links #9572
feat: [M3-6969] - Add DC Specific Pricing Notices and Docs Links #9572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Approving pending a couple improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notices and docs links are looking good -- we'll just want to make sure that we address the console warning happening on the Box
component.
packages/manager/src/features/Kubernetes/CreateCluster/CreateCluster.tsx
Show resolved
Hide resolved
packages/manager/src/components/SelectRegionPanel/RegionHelperText.tsx
Outdated
Show resolved
Hide resolved
@@ -303,6 +308,7 @@ export interface LinodeType extends BaseType { | |||
network_out: number; | |||
gpus: number; | |||
price: PriceObject; | |||
region_prices: RegionPriceObject[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not duplicate your changes, I'm going to leave this out of M3-6965 and pull your changes in once this is merged.
…ode#9572) * inital docs and notices * wip * clean up and unit test helper functions * add banner to lke create * dial in styles and behavior * Added changeset: Add DC Specific Pricing Notices and Docs Links * feedback * fix linode clone e2e test --------- Co-authored-by: Banks Nussman <banks@nussman.us>
…ode#9572) * inital docs and notices * wip * clean up and unit test helper functions * add banner to lke create * dial in styles and behavior * Added changeset: Add DC Specific Pricing Notices and Docs Links * feedback * fix linode clone e2e test --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Description 📝
Major Changes 🔄
Preview 📷
NodeBalancer Create
Linode Create
NodeBalancer Clone (to region with different price 💵)
Kubernetes Create
How to test 🧪