Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show DC Specific Pricing Notice on DBaaS Create Page #9607

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • DBaaS is out of scope for DC Specific Pricing so we should not show the pricing notice in the region helper text

Preview 📷

Before After
Screenshot 2023-08-30 at 10 14 51 AM Screenshot 2023-08-30 at 10 14 44 AM

How to test 🧪

  • Turn on DC Specific Pricing feature flag
  • Verify that you don't see the pricing notice on http://localhost:3000/databases/create

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!! Confirmed no region pricing notice on Database Create.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be okay without a changeset for this since it's a fix following #9572, which has not been released.

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 30, 2023
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2023
@bnussman-akamai bnussman-akamai merged commit e57aa74 into linode:develop Aug 30, 2023
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
…de#9607)

* hide notice on databases create

* Added changeset: Don't show DC Specific Pricing Notice on DBaaS Create Page

* Delete packages/manager/.changeset/pr-9607-upcoming-features-1693405020392.md

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DC-Specific Pricing Missing Changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants