-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-7250] β Properly surface VPC interface errors #9839
change: [M3-7250] β Properly surface VPC interface errors #9839
Conversation
β¦rrors and fixed formatting of error in Linode Config dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I observed both errors following the provided testing instructions. β
One clarification question:
Try adding two VPC interfaces and check the "Assign a public IPv4 address for this Linode" checkbox for both of them
This means two distinct VPC interfaces, correct? A user is allowed to configure the same VPC on multiple network interfaces, and should not expect to see that error?
packages/manager/.changeset/pr-9839-upcoming-features-1698180186838.md
Outdated
Show resolved
Hide resolved
β¦86838.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
I tried assigning the same VPC and subnet for each interface and observed the error π€ In verifying this, though, I did come across a bug earlier: trying to submit an initial combo that yields the error, and then changing the selected VPC and subnet resulted in a successful submission despite that interface slot's "Assign a public IPv4 address for this Linode" checkbox being checked. That may have been what you were actually running into? I believe this was happening because |
β¦g discarded upon a VPC or subnet selection change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trying to submit an initial combo that yields the error, and then changing the selected VPC and subnet resulted in a successful submission despite that interface slot's "Assign a public IPv4 address for this Linode" checkbox being checked. That may have been what you were actually running into?
Hmm, must have been? I thought the first attempt that I made was with assinging the same VPC and subnet to eth0
and eth1
, and did not see the expected error, at which point I went on to try (and see it successfully) with two different VPCs and subnets. In any case, I retested with the latest changes and am consistently seeing the expected Linode has no public IP to use for 1:1 NAT
error when creating/editing an interface with two VPC interfaces and checked "Assign a public IPv4 address for this Linode", regardless of whether the VPCs were the same, different, or changed and then resubmitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description π
There was an API bug for API endpoints that take a list of interfaces where, if there was an error for one of the interfaces, the
field
of the error didn't indicate which interface index it applied to. This presented difficulties for surfacing the errors in the UI. Temporary code was added in #9709 to surface the errors in a general way just so that they wouldn't stay submerged, but since the API fix has been merged in, that temporary code is being removed so the errors surface and map to the appropriate interfaces.Changes π
LinodeConfigDialog.tsx
publicIPv4Error
outside of<Box />
inVPCPanel.tsx
to avoid odd formatting of error in the Add/Edit Linode Config dialogPreview π·
(for the
publicIPv4Error
error change -- this error is only really possible to get back in the Linode Config flow, not the Linode Create flow)How to test π§ͺ
Prerequisites
dev
environmentVerification steps
Try adding a Linode config or editing an existing config:
As an Author I have considered π€
Check all that apply