Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-7250] – Properly surface VPC interface errors #9839

Merged
merged 6 commits into from
Oct 31, 2023
Merged

change: [M3-7250] – Properly surface VPC interface errors #9839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
625919e
Remove temp logic for surfacing ipv4.vpc and ipv4.nat_1_1 errors
DevDW Oct 24, 2023
d8b484d
Move error outside of <Box /> to prevent crunched formatting
DevDW Oct 24, 2023
7451d78
Added changeset: Removed temporary code for surfacing VPC interface e…
DevDW Oct 24, 2023
277d6aa
Update packages/manager/.changeset/pr-9839-upcoming-features-16981801…
dwiley-akamai Oct 25, 2023
bd8898a
Fix bug where the auto-assign a public IPv4 address checkbox was bein…
DevDW Oct 25, 2023
51f01e8
Undo unnecessary curly braces
DevDW Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-9839-upcoming-features-1698180186838.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Remove temporary code for surfacing VPC interface errors and fix formatting of error in Linode Config dialog ([#9839](https://github.com/linode/manager/pull/9839))
18 changes: 9 additions & 9 deletions packages/manager/src/features/Linodes/LinodesCreate/VPCPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,16 +304,16 @@ export const VPCPanel = (props: VPCPanelProps) => {
</Box>
}
/>
{assignPublicIPv4Address && publicIPv4Error && (
<Typography
sx={(theme) => ({
color: theme.color.red,
})}
>
{publicIPv4Error}
</Typography>
)}
</Box>
{assignPublicIPv4Address && publicIPv4Error && (
<Typography
sx={(theme) => ({
color: theme.color.red,
})}
>
{publicIPv4Error}
</Typography>
)}
</Stack>
)}
</Stack>
Expand Down
11 changes: 0 additions & 11 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeConfigs/LinodeConfigDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,20 +425,9 @@ export const LinodeConfigDialog = (props: Props) => {
});
};

// @TODO VPC: Remove this override and surface the field errors appropriately
// once API fixes interface index bug for ipv4.vpc & ipv4.nat_1_1 errors
const overrideFieldForIPv4 = (error: APIError[]) => {
error.forEach((err) => {
if (err.field && ['ipv4.nat_1_1', 'ipv4.vpc'].includes(err.field)) {
err.field = 'interfaces';
}
});
};

formik.setSubmitting(false);

overrideFieldForDevices(error);
overrideFieldForIPv4(error);

handleFieldErrors(formik.setErrors, error);

Expand Down
2 changes: 2 additions & 0 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeSettings/InterfaceSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ export const InterfaceSelect = (props: CombinedProps) => {
handleChange({
ipam_address: null,
ipv4: {
nat_1_1: autoAssignLinodeIPv4 ? 'any' : undefined,
vpc: autoAssignVPCIPv4 ? undefined : vpcIPv4,
},
label: null,
Expand All @@ -140,6 +141,7 @@ export const InterfaceSelect = (props: CombinedProps) => {
handleChange({
ipam_address: null,
ipv4: {
nat_1_1: autoAssignLinodeIPv4 ? 'any' : undefined,
vpc: autoAssignVPCIPv4 ? undefined : vpcIPv4,
},
label: null,
Expand Down