Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [M3-7550] - Add Lint To Github Actions #9973

Merged
merged 8 commits into from
Dec 12, 2023
Merged

ci: [M3-7550] - Add Lint To Github Actions #9973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a243d8c
add lint step for Cloud Manager
bnussman Dec 6, 2023
7cafe2a
don't lint storybook build js and fix eslint error
bnussman Dec 6, 2023
fcf6b84
try linting all packages
bnussman Dec 6, 2023
1b540a1
clean up strings
bnussman Dec 6, 2023
eeebf97
add changesets
bnussman Dec 7, 2023
dba3e03
Merge branch 'develop' into ci/add-lint-check
bnussman Dec 8, 2023
6e0d482
Merge branch 'develop' into ci/add-lint-check
bnussman Dec 8, 2023
0b75d3b
Merge branch 'develop' into ci/add-lint-check
bnussman Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,24 @@ on:
pull_request:

jobs:
lint:
strategy:
matrix:
package: ['linode-manager', '@linode/api-v4', '@linode/validation']
Comment on lines +14 to +15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty simple Github Actions stuff, but I'm proud of this 🧼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated - any reason we have linode-manager VS @linode/manager for CM workspace? I assume it is the legacy name pre-monorepo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely just a legacy thing. I think I would have named it @linode/manager if it were up to me!

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "18.14"
- uses: actions/cache@v3
with:
path: |
**/node_modules
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
- run: yarn --frozen-lockfile
- run: yarn workspace ${{ matrix.package }} run lint

build-validation:
runs-on: ubuntu-latest
steps:
Expand Down
5 changes: 5 additions & 0 deletions packages/api-v4/.changeset/pr-9973-tech-stories-1701959506143.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/api-v4": Tech Stories
---

Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973))
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-9973-tech-stories-1701959520658.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973))
1 change: 1 addition & 0 deletions packages/manager/.eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = {
ignorePatterns: [
'node_modules',
'build',
'storybook-static',
'.storybook',
'e2e',
'public',
Expand Down
6 changes: 4 additions & 2 deletions packages/manager/src/features/OneClickApps/oneClickApps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,8 @@ export const oneClickApps: OCA[] = [
'Deploy MainConcept FFmpeg Plugins Demo through the Linode Marketplace',
},
],
summary: 'MainConcept FFmpeg Plugins Demo contains advanced video encoding tools.',
summary:
'MainConcept FFmpeg Plugins Demo contains advanced video encoding tools.',
website: 'https://www.mainconcept.com/ffmpeg',
},
{
Expand All @@ -1159,7 +1160,8 @@ export const oneClickApps: OCA[] = [
{
href:
'https://www.linode.com/docs/products/tools/marketplace/guides/mainconcept-live-encoder-demo/',
title: 'Deploy MainConcept Live Encoder Demo through the Linode Marketplace',
title:
'Deploy MainConcept Live Encoder Demo through the Linode Marketplace',
},
],
summary: 'MainConcept Live Encoder is a real time video encoding engine.',
Expand Down
5 changes: 5 additions & 0 deletions packages/validation/.changeset/pr-9973-tech-stories-1701959541076.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/validation": Tech Stories
---

Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973))