Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: [M3-7550] - Add Lint To Github Actions #9973

Merged
merged 8 commits into from
Dec 12, 2023
Merged

ci: [M3-7550] - Add Lint To Github Actions #9973

merged 8 commits into from
Dec 12, 2023

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Dec 6, 2023 •
edited
Loading

Description 📝

  • Adds a Lint step in Github Actions for Cloud Manager's, api-v4, and validation ✅
    • This honestly should have been done years ago
    • For those of us who don't believe in pre-commit hooks, we can now commit without worrying about merging bad code 🎉
    • Another added benefit is that we'll more easily know if something about our eslint configuration breaks, which thankfully hasn't happened, but could

How to test 🧪

  • View Github Actions below 👀⬇️
    • You should see 3 new lint checks

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Dec 6, 2023
bnussman-akamai
bnussman-akamai commented Dec 6, 2023
View reviewed changes
packages/manager/.eslintrc.js Outdated
@@ -20,6 +20,7 @@ module.exports = {
ignorePatterns: [
'node_modules',
'build',
'storybook-static',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignores the storybook build directory.

This caused my local eslint to take hours to finish because it was trying to lint my local storybook build.

@bnussman-akamai bnussman-akamai marked this pull request as ready for review December 7, 2023 00:08
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 7, 2023 00:08
@bnussman-akamai bnussman-akamai requested review from jdamore-linode, tyler-akamai, jcallahan-akamai and abailly-akamai and removed request for a team December 7, 2023 00:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 77.17%
Current Coverage: 77.17%

@bnussman-akamai bnussman-akamai changed the title ci: Add Lint To Github Actions ci: [M3-7550] - Add Lint To Github Actions Dec 7, 2023
bnussman-akamai
bnussman-akamai commented Dec 7, 2023
View reviewed changes
.github/workflows/ci.yml
Comment on lines +14 to +15
matrix:
package: ['linode-manager', '@linode/api-v4', '@linode/validation']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty simple Github Actions stuff, but I'm proud of this 🧼

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated - any reason we have linode-manager VS @linode/manager for CM workspace? I assume it is the legacy name pre-monorepo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely just a legacy thing. I think I would have named it @linode/manager if it were up to me!

@tyler-akamai
Copy link
Contributor

LGTM, excited to see this in action

abailly-akamai
abailly-akamai approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Thanks for implementing

.github/workflows/ci.yml
Comment on lines +14 to +15
matrix:
package: ['linode-manager', '@linode/api-v4', '@linode/validation']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated - any reason we have linode-manager VS @linode/manager for CM workspace? I assume it is the legacy name pre-monorepo?

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Dec 11, 2023
@bnussman-akamai bnussman-akamai merged commit 0ad0937 into linode:develop Dec 12, 2023
18 checks passed
@bnussman-akamai bnussman-akamai mentioned this pull request Dec 12, 2023
Merged
12 tasks
@bnussman-akamai bnussman-akamai mentioned this pull request Jan 4, 2024
Merged
@bnussman-akamai bnussman-akamai mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-akamai tyler-akamai tyler-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

@jcallahan-akamai jcallahan-akamai Awaiting requested review from jcallahan-akamai

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @tyler-akamai @abailly-akamai @bnussman