Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Speed Up Code Coverage Github Actions Jobs #9988

Merged

Conversation

bnussman-akamai
Copy link
Member

Description 📝

Slightly speeds up our new code coverage Github Actions jobs by not building a production Cloud Manager bundle 🏎️

We should see an improvement of about 30-60 seconds ⏲️ Nothing groundbreaking, but slightly better.

How to test 🧪

  • Check the GitHub Actions below this PR and verify that the Code Coverage jobs work as expected

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Performance Increase performance of CM label Dec 11, 2023
@bnussman-akamai bnussman-akamai self-assigned this Dec 11, 2023
@bnussman-akamai bnussman-akamai marked this pull request as ready for review December 11, 2023 23:16
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner December 11, 2023 23:16
@bnussman-akamai bnussman-akamai requested review from mjac0bs and carrillo-erik and removed request for a team December 11, 2023 23:16
Copy link

Coverage Report:
Base Coverage: 77.15%
Current Coverage: 77.18%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! small improvement, wondering what prompted you to want to improve the speed here. This action is non blocking and we usually want to wait for the e2e suite to finish before merging anyway, which takes far more time.

If we really want to improve speed here, we could upload the base coverage pct to another bucket on every merge to develop and download it on each run so we don't have to run the unit suite on the ref branch. Would cut the job time by almost half but unless I am missing a particular use case I dunno if worth the effort?

@bnussman-akamai
Copy link
Member Author

No significant reason, I just noticed we could skip the Cloud Manager build when I did #9973

If we really want to improve speed here, we could upload the base coverage pct to another bucket on every merge to develop and download it on each run so we don't have to run the unit suite on the ref branch. Would cut the job time by almost half but unless I am missing a particular use case I dunno if worth the effort?

I thought about this, but I appreciate the simplicity of how it is now and the fact that it can dynamically get the coverage of the base_ref

@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 12, 2023
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the action works to produce the coverage report and we see a small increase in speed:

Action run on this branch:
Screenshot 2023-12-11 at 9 45 18 PM

Action run on another PR branch:
Screenshot 2023-12-11 at 9 46 34 PM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 12, 2023
@bnussman-akamai bnussman-akamai merged commit 645284c into linode:develop Dec 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Performance Increase performance of CM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants