-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Speed Up Code Coverage Github Actions Jobs #9988
ci: Speed Up Code Coverage Github Actions Jobs #9988
Conversation
…ng Cloud Manager build
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! small improvement, wondering what prompted you to want to improve the speed here. This action is non blocking and we usually want to wait for the e2e suite to finish before merging anyway, which takes far more time.
If we really want to improve speed here, we could upload the base coverage pct to another bucket on every merge to develop
and download it on each run so we don't have to run the unit suite on the ref branch. Would cut the job time by almost half but unless I am missing a particular use case I dunno if worth the effort?
No significant reason, I just noticed we could skip the Cloud Manager build when I did #9973
I thought about this, but I appreciate the simplicity of how it is now and the fact that it can dynamically get the coverage of the base_ref |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description 📝
Slightly speeds up our new code coverage Github Actions jobs by not building a production Cloud Manager bundle 🏎️
We should see an improvement of about 30-60 seconds ⏲️ Nothing groundbreaking, but slightly better.
How to test 🧪
As an Author I have considered 🤔