Provide own basename API implementation #1467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Again, why don't we try to convert the callers over to the POSIX behavior? That seems a bit better doesn't it? |
that needs testing, and I am not that familiar with rdma-core code to do it. |
basename prototype has been removed from string.h from latest musl [1] compilers e.g. clang-18 flags the absense of prototype as error, it turns out the basename has two different implementations and musl only provides POSIX implementation, whereas glibc has GNU version and posix version both depending upon if string.h is included or not it will pick GNU version, to avoid this dependency, lets implement own basename function which reflects GNU basename behavior, it will work across all libcs [1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7 Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
It was fixed in @nmorey PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basename prototype has been removed from string.h from latest musl [1] compilers e.g. clang-18 flags the absense of prototype as error, it turns out the basename has two different implementations and musl only provides POSIX implementation, whereas glibc has GNU version and posix version both depending upon if string.h is included or not it will pick GNU version,
to avoid this dependency, lets implement own basename function which reflects GNU basename behavior, it will work across all libcs
[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7