feat: detects and error if the tiff is not 8 bits TDE-895 #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
requested review from
l0b0,
blacha,
amfage,
MDavidson17 and
Wentao-Kuang
l0b0
reviewed
Mar 25, 2024
l0b0
reviewed
Mar 25, 2024
src/commands/tileindex-validate/__test__/tileindex.validate.test.ts
Outdated
Show resolved
Hide resolved
l0b0
reviewed
Mar 25, 2024
Do you mean merging the package upgrade with a separate PR before having this PR? |
l0b0
previously approved these changes
Mar 25, 2024
l0b0
previously approved these changes
Mar 25, 2024
blacha
reviewed
Mar 27, 2024
Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
l0b0
approved these changes
Mar 27, 2024
blacha
approved these changes
Mar 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
🤖 I have created a release *beep* *boop* --- ## [3.4.0](v3.3.2...v3.4.0) (2024-04-03) ### Features * **basemaps:** Update the create-pr cli to add new individual vector tileset. BM-992 ([#933](#933)) ([9234ffb](9234ffb)) * detects and error if the tiff is not 8 bits TDE-895 ([#890](#890)) ([9e639b7](9e639b7)) * force fully qualified domains for s3 requests TDE-1084 ([#940](#940)) ([3fdbf98](3fdbf98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The standardising workflow is only processing 8 bits TIFFs at the moment.
Modification
In order to exclude any other TIFF than 8 bits ones, tileindex-validate throw an error if one TIFF is not 8 bits.
TODO: unit test - need to mock the TIFF tag BitsPerSampleAdded some test files.Checklist