Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(basemaps): Update the create-pr cli to add new individual vector tileset. BM-992 #933

Merged
merged 25 commits into from
Apr 3, 2024
Merged

feat(basemaps): Update the create-pr cli to add new individual vector tileset. BM-992 #933

merged 25 commits into from
Apr 3, 2024

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Mar 21, 2024 •
edited
Loading

Motivation

We need to run another cron workflow to generate individual vector map output for the nz road addressing layer. So we need to allow the create-pr command to be able to add create pull request for it.

Modification

  • Remove the hard coded topographic vector tileset logic
  • Update the vector to parse the info from vector target and prepare new tileset for it.
  • Update getContent to return null for Not Found

Checklist

If not applicable, provide explanation of why.

  • Tests updated - No related tests.
  • Docs updated - Doc no need to update
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang requested review from a team as code owners March 21, 2024 00:45
@Wentao-Kuang Wentao-Kuang changed the title feat(basemaps): Update the create-pr cli to add new individual vector tileset. feat(basemaps): Update the create-pr cli to add new individual vector tileset. BM-992 Mar 21, 2024
@Wentao-Kuang @blacha
Update src/commands/basemaps-github/create-pr.ts
9fd8276 
Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
l0b0
l0b0 reviewed Mar 21, 2024
View reviewed changes
src/commands/basemaps-github/create-pr.ts Show resolved Hide resolved
src/utils/github.ts Outdated Show resolved Hide resolved
blacha
blacha reviewed Mar 25, 2024
View reviewed changes
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
l0b0
l0b0 reviewed Mar 27, 2024
View reviewed changes
src/commands/basemaps-github/create-pr.ts Outdated Show resolved Hide resolved
src/utils/github.ts Show resolved Hide resolved
src/utils/github.ts Outdated Show resolved Hide resolved
src/utils/github.ts Outdated Show resolved Hide resolved
src/utils/github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/make.cog.github.ts Outdated Show resolved Hide resolved
l0b0
l0b0 previously approved these changes Mar 27, 2024
View reviewed changes
l0b0
l0b0 previously approved these changes Apr 3, 2024
View reviewed changes
blacha
blacha reviewed Apr 3, 2024
View reviewed changes
src/utils/github.ts Outdated Show resolved Hide resolved
@Wentao-Kuang @blacha
Update src/utils/github.ts
e8261cb 
Co-authored-by: Blayne Chard <bchard@linz.govt.nz>
@Wentao-Kuang Wentao-Kuang requested review from l0b0 and blacha April 3, 2024 20:08
@Wentao-Kuang Wentao-Kuang added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit 9234ffb Apr 3, 2024
2 checks passed
@Wentao-Kuang Wentao-Kuang deleted the feat/new-vector-config branch April 3, 2024 21:15
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 7, 2024
@github-actions
chore(master): release 3.4.0 (#941)
74b0907 
🤖 I have created a release *beep* *boop*
---


## [3.4.0](v3.3.2...v3.4.0)
(2024-04-03)


### Features

* **basemaps:** Update the create-pr cli to add new individual vector
tileset. BM-992 ([#933](#933))
([9234ffb](9234ffb))
* detects and error if the tiff is not 8 bits TDE-895
([#890](#890))
([9e639b7](9e639b7))
* force fully qualified domains for s3 requests TDE-1084
([#940](#940))
([3fdbf98](3fdbf98))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

@l0b0 l0b0 l0b0 approved these changes

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@paulfouquet paulfouquet Awaiting requested review from paulfouquet paulfouquet is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wentao-Kuang @l0b0 @blacha