-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Authorized redirect URIs explaination #54
Conversation
WalkthroughThe update to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: .coderabbit.yaml
Files selected for processing (1)
- docs/deploy-manual.md (1 hunks)
Additional comments: 2
docs/deploy-manual.md (2)
- 252-261: > Note: This review was outside the patches, and no patch overlapping with it was found. Original lines [10-10]
The addition of "Authorized redirect URIs" to the Table of Contents is a good way to inform the reader that there is now information available on this topic.
- 252-261: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-258]
Overall, the documentation is well-structured and the new section on "Authorized redirect URIs" integrates seamlessly with the existing content. The formatting is consistent throughout the document, and the instructions are clear, which should help users in setting up their deployment correctly.
In this pattern, you need to set Authorized redirect URIs in OAuth credentials. | ||
|
||
like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation of setting Authorized redirect URIs for the Identity-Aware Proxy Pattern is clear and concise. It's good that an example URI is provided, but it may be beneficial to explain why this specific URI format is required and what each part of the URI signifies.
- like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect`
+ like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` (Here, `[YOUR_CLIENT_ID]` should be replaced with the actual client ID obtained from your OAuth credentials. This URI format is required by the Identity-Aware Proxy to correctly handle the OAuth redirect.)
Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
In this pattern, you need to set Authorized redirect URIs in OAuth credentials. | |
like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` | |
In this pattern, you need to set Authorized redirect URIs in OAuth credentials. | |
like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` (Here, `[YOUR_CLIENT_ID]` should be replaced with the actual client ID obtained from your OAuth credentials. This URI format is required by the Identity-Aware Proxy to correctly handle the OAuth redirect.) | |
Summary by CodeRabbit