Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Authorized redirect URIs explaination #54

Merged
merged 1 commit into from
Jan 9, 2024
Merged

add Authorized redirect URIs explaination #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/deploy-manual.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,10 @@ see below, and another process is same as Google OAuth Pattern.
- [Managing access to IAP-secured resources](https://cloud.google.com/iap/docs/managing-access?hl=en)
- [Enabling IAP for Cloud Run](https://cloud.google.com/iap/docs/enabling-cloud-run?hl=en)

In this pattern, you need to set Authorized redirect URIs in OAuth credentials.

like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect`

Comment on lines +255 to +258
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation of setting Authorized redirect URIs for the Identity-Aware Proxy Pattern is clear and concise. It's good that an example URI is provided, but it may be beneficial to explain why this specific URI format is required and what each part of the URI signifies.

- like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect`
+ like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` (Here, `[YOUR_CLIENT_ID]` should be replaced with the actual client ID obtained from your OAuth credentials. This URI format is required by the Identity-Aware Proxy to correctly handle the OAuth redirect.)
Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
In this pattern, you need to set Authorized redirect URIs in OAuth credentials.
like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect`
In this pattern, you need to set Authorized redirect URIs in OAuth credentials.
like: `https://iap.googleapis.com/v1/oauth/clientIds/[YOUR_CLIENT_ID]:handleRedirect` (Here, `[YOUR_CLIENT_ID]` should be replaced with the actual client ID obtained from your OAuth credentials. This URI format is required by the Identity-Aware Proxy to correctly handle the OAuth redirect.)

### 2. Prepare

You need to follow the same procedure as Google OAuth Pattern. Please follow from [3. Enable APIs](#3-enable-apis).
Expand Down