Refactor base types

netlink-packet-audit/src/rules/buffer.rs

@@ -175,14 +175,8 @@ impl<'a, T: AsRef<[u8]> + ?Sized> Parseable<RuleBuffer<&'a T>> for RuleMessage {
 
         let mut offset = 0;
 
-        let fields = buf
-            .fields()
-            .chunks(4)
-            .map(|chunk| NativeEndian::read_u32(chunk));
-        let values = buf
-            .values()
-            .chunks(4)
-            .map(|chunk| NativeEndian::read_u32(chunk));
+        let fields = buf.fields().chunks(4).map(NativeEndian::read_u32);
+        let values = buf.values().chunks(4).map(NativeEndian::read_u32);
         let field_flags = buf
             .field_flags()
             .chunks(4)

netlink-proto/src/framed.rs

@@ -125,8 +125,7 @@ impl<C: Encoder<Item> + Unpin, Item> Sink<(Item, SocketAddr)> for NetlinkFramed<
             Err(io::Error::new(
                 io::ErrorKind::Other,
                 "failed to write entire datagram to socket",
-            )
-            .into())
+            ))
         };
 
         Poll::Ready(res)

netlink-sys/src/smol.rs

@@ -66,14 +66,14 @@ impl SmolSocket {
             trace!("poll_recv_from socket is ready for reading");
 
             match self.0.get_ref().recv_from(buf, 0) {
-                Ok(x) => {
-                    trace!("poll_recv_from {:?} bytes read", x);
-                    return Poll::Ready(Ok(x));
-                }
-                Err(_would_block) => {
+                Err(e) if e.kind() == io::ErrorKind::WouldBlock => {
                     trace!("poll_recv_from socket would block");
                     continue;
                 }
+                x => {
+                    trace!("poll_recv_from {:?} bytes read", x);
+                    return Poll::Ready(x);
+                }
             }
         }
     }