Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

netlink-packet-sock-diag: Add TcpInfo parsing #211

Merged
merged 3 commits into from
Feb 12, 2022
Merged

netlink-packet-sock-diag: Add TcpInfo parsing #211

merged 3 commits into from
Feb 12, 2022

Conversation

svart
Copy link
Contributor

@svart svart commented Dec 4, 2021

No description provided.

little-dude
little-dude approved these changes Dec 19, 2021 •
edited
Loading
View reviewed changes
@little-dude little-dude self-requested a review December 19, 2021 08:49
@little-dude
Copy link
Owner

little-dude commented Dec 19, 2021 •
edited
Loading

Ah sorry I meant to click "request changes", not approve. Seems that I can't change this =/ Done now. Just needed to re-review.

@little-dude
Copy link
Owner

Oh I just noticed that my comment didn't even go through, sorry @svart :(

I'd like to have this TcpInfo parsing but only with --features rich-nlas. See: #199

little-dude
little-dude suggested changes Dec 28, 2021
View reviewed changes
Copy link
Owner

@little-dude little-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this opt-in via --features=rich-nlas just to be safe.

@svart
Copy link
Contributor Author

svart commented Dec 31, 2021

Let's make this opt-in via --features=rich-nlas just to be safe.

Ok! I will do it right after the holidays.

@svart
Copy link
Contributor Author

svart commented Jan 22, 2022

Let's make this opt-in via --features=rich-nlas just to be safe.

Uploaded the patch. @little-dude could you please trigger the CI?

@little-dude little-dude merged commit bda893b into little-dude:master Feb 12, 2022
@little-dude
Copy link
Owner

Thanks a lot @svart :) I'll make a release now.

@little-dude
Copy link
Owner

Released 0.4.0!

@svart svart deleted the parse_tcp_info branch July 9, 2022 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@little-dude little-dude little-dude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svart @little-dude