Bridge: add support for specifying IFLA_BRIDGE_FLAGS and implement Flags
#212
Conversation
Add support for setting `IFLA_BRIDGE_FLAGS` to bridge management nested attributes. Can accept flags such `BRIDGE_FLAGS_MASTER` and `BRIDGE_FLAGS_SELF` Signed-off-by: Aditya Rajan <arajan@redhat.com>
Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
extend_bridge_link_info
branch
from
db8911a to
d49dfba
Compare
| @@ -394,6 +394,11 @@ pub const IFLA_INFO_DATA: u16 = 2; | |||
| pub const IFLA_INFO_XSTATS: u16 = 3; | |||
| pub const IFLA_INFO_SLAVE_KIND: u16 = 4; | |||
| pub const IFLA_INFO_SLAVE_DATA: u16 = 5; | |||
| // Bridge flags | |||
| pub const IFLA_BRIDGE_FLAGS: u16 = 47; | |||
There was a problem hiding this comment.
I really wanted this to be 0 but code has implemented IFLA_BR_XXXX for bridge which blocks 0.
I think IFLA_BR_XXXXX should be implemented for a general link not for InfoBridge but trying not to break what is already there.
There was a problem hiding this comment.
Sorry I don't understand what you mean. Are you saying IFLA_BRIDGE_FLAGS can't be named IFLA_BR_FLAGS?
|
@cathay4t @little-dude PTAL |
|
Sorry @flouthoc I'll try to review this tonight |
|
@little-dude I am a bit unsure about using But I'm fine to change it, if that is needed. Not a problem for me 😄 |
|
Sorry for taking so long @flouthoc and thanks for your PR. |
Extends
InfoBridgeto supportFlagsAdd support for setting
IFLA_BRIDGE_FLAGSto bridge management nested attributes. Can accept flags suchBRIDGE_FLAGS_MASTERandBRIDGE_FLAGS_SELF