Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

bridge: add support for setting IFLA_BRIDGE_VLAN_INFO #213

Merged
merged 2 commits into from
Dec 29, 2021
Merged

bridge: add support for setting IFLA_BRIDGE_VLAN_INFO #213

merged 2 commits into from
Dec 29, 2021

Conversation

flouthoc
Copy link
Contributor

Extends InfoBridge to support Flags

Add support for setting IFLA_BRIDGE_VLAN_INFO to bridge management nested attributes.

        BRIDGE_VLAN_INFO_MASTER = 1
        BRIDGE_VLAN_INFO_PVID = 4
        BRIDGE_VLAN_INFO_UNTAGGED = 8
        BRIDGE_VLAN_INFO_RANGE_BEGIN = 16
        BRIDGE_VLAN_INFO_RANGE_END = 32

@flouthoc
Copy link
Contributor Author

I want to rebase this after: #212

@little-dude little-dude self-requested a review December 19, 2021 08:45
little-dude
little-dude approved these changes Dec 19, 2021
View reviewed changes
Copy link
Owner

@little-dude little-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good, I'll merge after #212. Like in #212 though, why can't IFLA_BRIDGE_VLAN_INFO be name IFLA_BR_VLAN_INFO?

@little-dude
Copy link
Owner

You can now rebase this @flouthoc :) Thanks!

@flouthoc
bridge: add support for setting IFLA_BRIDGE_VLAN_INFO
e3a8577 
Extends InfoBridge to support Flags

Add support for setting IFLA_BRIDGE_VLAN_INFO to bridge management nested attributes.
Can accept flags such BRIDGE_FLAGS_MASTER and BRIDGE_FLAGS_SELF

	BRIDGE_VLAN_INFO_MASTER = 1
	BRIDGE_VLAN_INFO_PVID = 4
	BRIDGE_VLAN_INFO_UNTAGGED = 8
	BRIDGE_VLAN_INFO_RANGE_BEGIN = 16
	BRIDGE_VLAN_INFO_RANGE_END = 32

Signed-off-by: Aditya Rajan <arajan@redhat.com>
@flouthoc
constants: add supported values for IFLA_BRIDGE_VLAN_INFO
5287cb5 
Signed-off-by: Aditya Rajan <arajan@redhat.com>
@flouthoc flouthoc force-pushed the extend_bridge_vlan_info branch from eebabeb to 5287cb5 Compare December 28, 2021 15:12
@flouthoc flouthoc requested a review from little-dude December 28, 2021 15:14
@flouthoc
Copy link
Contributor Author

@little-dude Thanks :) rebased

@little-dude
Copy link
Owner

Thanks @flouthoc !

@little-dude little-dude merged commit 8d3db04 into little-dude:master Dec 29, 2021
flouthoc
flouthoc commented Dec 29, 2021
View reviewed changes
Copy link
Contributor Author

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also add methods for this in high-level API once i implement it.

@little-dude little-dude mentioned this pull request Dec 29, 2021
Merged
@flouthoc flouthoc mentioned this pull request Jan 3, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@little-dude little-dude Awaiting requested review from little-dude

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flouthoc @little-dude