Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the ProcessInterface #8

Open
EmanueleMinotto opened this issue Oct 5, 2015 · 6 comments
Open

Extend the ProcessInterface #8

EmanueleMinotto opened this issue Oct 5, 2015 · 6 comments
Labels

Comments

@EmanueleMinotto
Copy link
Collaborator

Currently the ProcessInterface is incomplete because if a final developer creates something implementing the ProcessInterface without extending a Symfony\Component\Process\Process than Spawn will give him/her different errors (for example here).

The Symfony\Component\Process\Process doesn't implement an interface so something custom for Spawn should be created starting from Process APIs(?).

@liuggio
Copy link
Owner

liuggio commented Oct 5, 2015

The process interface should have also some methods from Symfony Process.

@EmanueleMinotto
Copy link
Collaborator Author

What about an abstract class requirement instead of an interface?

@liuggio
Copy link
Owner

liuggio commented Oct 5, 2015

Interface is the contract

@EmanueleMinotto
Copy link
Collaborator Author

👍

@liuggio
Copy link
Owner

liuggio commented Oct 5, 2015

is quite controversial here, we have a lot of behavior of ClosureProcess that are not implemented on the Process side, and also they act differently.
Do we have another way instead of a big interface with wait and returnValue?

@EmanueleMinotto
Copy link
Collaborator Author

Good question, I still don't know :
Can you list those ClosureProcess behaviours in a new issue as a to do list, please?

EmanueleMinotto added a commit that referenced this issue Oct 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants