Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Podspec #587

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Update Podspec #587

merged 2 commits into from
Feb 13, 2025

Conversation

hiroshihorie
Copy link
Member

Fixes: #566

@hiroshihorie hiroshihorie merged commit 5b031c8 into main Feb 13, 2025
12 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/update-pod branch February 13, 2025 13:36
hiroshihorie added a commit to ladvoc/client-sdk-swift that referenced this pull request Feb 13, 2025
commit aa0a21d
Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com>
Date:   Thu Feb 13 06:28:21 2025 -0800

    Simplify broadcast extension setup with standard format for identifiers (livekit#573)

    When configuring a broadcast extension, manually setting the info keys
    `RTCAppGroupIdentifier` and `RTCScreenSharingExtension` is no longer
    required when using the standard format. The standard format is as
    follows:
    - App group: `group.<main-app-bundle-id>`
    - Broadcast extension: `<main-app-bundle-id>.broadcast`

    ---------

    Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>

commit c3ee701
Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com>
Date:   Thu Feb 13 06:05:00 2025 -0800

    Deprecate public broadcast picker extension (livekit#586)

    Public show method defined as an extension to
    `RPSystemBroadcastPickerView` has been deprecated in favor of
    `BroadcastManager.shared.requestActivation()`.

    ---------

    Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>

commit 0da6660
Author: Jacob Gelman <3182119+ladvoc@users.noreply.github.com>
Date:   Thu Feb 13 05:55:25 2025 -0800

    Release automation (livekit#579)

    - Add version and platform compatibility badges from [Swift Package
    Index](https://swiftpackageindex.com/) to README
      - Automatically updated on each release
    - Add [nanpa](https://github.com/nbsp/nanpa) configuration
    - Custom script bumps version across repo (currently Podspec, README,
    and LiveKitSDK class)
      - GitHub publish workflow (based on workflow from livekit/rust-sdks)
    - Create workflow to push new releases to Cocopods when a release is
    published on GitHub

    I have also added changeset files to my currently open PRs (livekit#565, livekit#576,
    and livekit#573) that can be used to test this configuration.

    ---------

    Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>

commit 5b031c8
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date:   Thu Feb 13 22:36:35 2025 +0900

    Update Podspec (livekit#587)

    Fixes: livekit#566

commit 485e76d
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date:   Wed Feb 12 14:36:48 2025 +0900

    macOS screen share audio (livekit#561)
@ladvoc
Copy link
Contributor

ladvoc commented Feb 14, 2025

I found this change causes pod spec lint to fail with the following error:

- ERROR | [tvOS] unknown: Encountered an unknown error (The platform of the target `App` (tvOS 17.0) is not compatible with `LiveKitWebRTC (125.6422.18)`, which does not support `tvOS`.

I think adding the TV and VisionOS versions to the Podspec in webrtc-xcframework would fix this issue.

@hiroshihorie
Copy link
Member Author

Thanks @ladvoc Yes we should add it there also 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveKitClient.podspec don't have tvos.deployment_target
2 participants