Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

>= go1.15.5 Linux & Darwin #1677

Merged
merged 4 commits into from
Dec 9, 2020
Merged

>= go1.15.5 Linux & Darwin #1677

merged 4 commits into from
Dec 9, 2020

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Dec 2, 2020 •
edited
Loading

  • Use go1.15.5 for Linux. A tar archive is downloaded from dl.google.com instead of installing using apt because the most recent version in the longsleep/golang-backports repo is go1.15.2.
  • Use go1.15.x for Darwin. At the moment, the latest version is go1.15.6
  • Fix a test that broke after the switch to go1.15.5 for linux

Upgrading to >= go1.15.5 for Windows is a bit trickier so I left that for #1701.

Not sure if this actually resolves #1700, but at least the tests pass for this PR. Will leave that issue open for a bit and observe if it is still a problem.

Fixes #1668

@yondonfu yondonfu changed the base branch from master to jai/txbench December 2, 2020 18:05
Base automatically changed from jai/txbench to master December 2, 2020 22:45
@yondonfu yondonfu force-pushed the yf/ci-mem-go branch 4 times, most recently from f5daea2 to d979cfa Compare December 8, 2020 23:12
@yondonfu yondonfu marked this pull request as ready for review December 9, 2020 01:38
@yondonfu yondonfu changed the title go1.15 Linux >= go1.15.5 Linux & Darwin Dec 9, 2020
darkdarkdragon
darkdarkdragon approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yondonfu yondonfu merged commit 8f520a7 into master Dec 9, 2020
@yondonfu yondonfu deleted the yf/ci-mem-go branch December 9, 2020 01:51
This was referenced Jan 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdarkdragon darkdarkdragon darkdarkdragon approved these changes

@iameli iameli Awaiting requested review from iameli

@kyriediculous kyriediculous Awaiting requested review from kyriediculous

@jailuthra jailuthra Awaiting requested review from jailuthra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: /usr/lib/go-1.13/pkg/tool/linux_amd64/link: signal: killed Upgrade to go 1.15.5
2 participants
@yondonfu @darkdarkdragon