Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg: Throw error instead of bypassing for audio-only stream #207

Merged
merged 1 commit into from
Sep 24, 2020
Merged

ffmpeg: Throw error instead of bypassing for audio-only stream #207

merged 1 commit into from
Sep 24, 2020

Conversation

jailuthra
Copy link
Contributor

What is done?

  • Reverted the bypassing performed for initial segments with broken video streams.
  • Retained the detection code and now throw an early error for such streams to prevent the extra-cost associated with initializing contexts for decoding.

Why?
The original error is not reproducible anymore, and the current state of master which bypasses segments altogether may cause issues with playback and is not a stable well-tested solution.

@jailuthra jailuthra requested a review from yondonfu September 24, 2020 11:26
yondonfu
yondonfu approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jailuthra jailuthra merged commit d5c85d8 into master Sep 24, 2020
@jailuthra jailuthra deleted the jai/onlyaudio branch September 24, 2020 13:33
@jailuthra jailuthra mentioned this pull request Sep 24, 2020
Merged
3 tasks
@yondonfu yondonfu mentioned this pull request Jan 21, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jailuthra @yondonfu