-
Notifications
You must be signed in to change notification settings - Fork 0
Notes for Refactoring
Li-Wei Yap edited this page Jun 24, 2021
·
4 revisions
See here.
- Managed to do major refactoring; see commits 41f10e6 and 8407598. The only function left unrefactored is
addSoundToPlayOnButtonClick(). - If we wish to refactor
SettingsBackgroundActivity, we should note the left and right panels must be in the same control group because the long click of the buttons in the left panel requires the value of the volume from the right panel. If the right panel is too simple to require refactoring, then we have to refactor the left panel alone, but it is impossible to do so as the left panel cannot be separated from the right panel.