This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
chore: try removing the ignored_error_codes specified in foundry.toml
#58
Assignees
Labels
Comments
Closed
AustinGreen
added a commit
that referenced
this issue
Mar 15, 2023
…rors to interfaces (#150) **Motivation:** Addressed a few smaller bug fixes and refactors that will improve our code quality. - Closes #58 - Closes #132 - Closes #134 - Closes #136 **Modifications:** Moved all errors to their interfaces to clean up the contracts, added a policyholder check for submitting approvals and disapprovals, fixed the name of the test profile in `ci.yml`, and removed `ignored_error_codes` in `foundry.toml`. **Result:** Code will be safer and more consistent.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
func-mutabilityis ignored because NFT'stransferFromalways reverts so it can bepure. We should make it pure and remove thisunreachableis ignored because the ERC-721 transfer logic can't be reached since it always reverts. I'd recommend removing this for now so we find out about any additional unreachable code that's accidentally introducedThe text was updated successfully, but these errors were encountered: