This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
fix: add policyholder check to approvals and disapprovals and move errors to interfaces #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinGreen
requested review from
0xrajath,
efecarranza and
dd0sxx
as code owners
March 14, 2023 00:32
mds1
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
mds1
approved these changes
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
reviewed
Mar 14, 2023
0xrajath
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Addressed a few smaller bug fixes and refactors that will improve our code quality.
ignored_error_codes
specified infoundry.toml
#58Modifications:
Moved all errors to their interfaces to clean up the contracts, added a policyholder check for submitting approvals and disapprovals, fixed the name of the test profile in
ci.yml
, and removedignored_error_codes
infoundry.toml
.Result:
Code will be safer and more consistent.