Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

fix: add policyholder check to approvals and disapprovals and move errors to interfaces #150

Merged
merged 11 commits into from
Mar 15, 2023

Conversation

AustinGreen
Copy link
Contributor

Motivation:

Addressed a few smaller bug fixes and refactors that will improve our code quality.

Modifications:

Moved all errors to their interfaces to clean up the contracts, added a policyholder check for submitting approvals and disapprovals, fixed the name of the test profile in ci.yml, and removed ignored_error_codes in foundry.toml.

Result:

Code will be safer and more consistent.

src/VertexCore.sol Outdated Show resolved Hide resolved
.gas-report Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

Coverage after merging austin/issue-followups into main will be

59.65%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   VertexAccount.sol100%100%100%100%
   VertexCore.sol89.78%87.04%78.95%92.92%101, 103, 180, 187–188, 188, 188–189, 202, 209–210, 210, 210–211, 297
   VertexFactory.sol100%100%100%100%
   VertexLens.sol76.47%100%71.43%80%93, 97
   VertexPolicy.sol46.63%26.47%57.14%50.93%104, 106–107, 107, 107–108, 110–111, 118, 120–122, 140, 140, 140–142, 144–146, 149–151, 155–158, 158, 158–159, 162–164, 166, 166, 166–167, 167, 167–168, 177, 184–185, 185–186, 186, 186–187, 205, 205, 205, 207–209, 212–213, 217–218, 241, 250, 265, 279, 287, 48, 63, 67–68, 68, 68–69, 80–81, 86–87, 95–98
   VertexStrategy.sol76.32%50%83.33%78.57%104, 114, 76–78, 82–84
src/lib
   Checkpoints.sol0%0%0%0%105, 105, 105–106, 108, 110–111, 113, 113, 113–115, 115, 115–116, 118, 122, 124, 124, 124–126, 136, 146, 153–154, 171–172, 172, 172–173, 175–176, 184, 197, 199, 199, 199, 201, 204, 204, 204, 207, 207, 207–210, 212, 214, 216–217, 234–236, 236, 236–237, 239, 242, 258–260, 260, 260–261, 263, 266, 276, 285, 294, 294, 294–295, 308, 315–322, 331, 333, 333, 333–335, 337, 337, 337–339, 341, 341, 341–343, 345, 345, 345–347, 349, 349, 349, 35, 35, 35, 350–351, 353, 353, 353–355, 357, 357, 357–359, 36, 361, 361, 361–362, 365, 372, 38, 380, 380, 380–381, 389, 389, 389, 39, 390, 40, 53, 53, 53–54, 56–57, 59, 59, 59–61, 71, 71, 71–72, 74, 76–77, 79, 79, 79–81, 81, 81–82, 84, 88, 90
   ERC721NonTransferableMinimalProxy.sol92.75%95.45%81.82%94.44%117, 189, 44

foundry.toml Show resolved Hide resolved
.gas-report Show resolved Hide resolved
Copy link
Contributor

@0xrajath 0xrajath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few comments

@AustinGreen AustinGreen merged commit 845295d into main Mar 15, 2023
@AustinGreen AustinGreen deleted the austin/issue-followups branch March 15, 2023 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants