Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgString Improvements #95

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

MsgString Improvements #95

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36e2d5d
This branch focuses on improvements on msgstringtable and any related…
llchrisll Oct 5, 2024
aaa8043
Quick fix of missing "
llchrisll Oct 5, 2024
7024adf
Changed validate name in RODEX to Check Name
llchrisll Oct 5, 2024
752910b
Applied suggestions by Haydrich
llchrisll Oct 14, 2024
1171b4f
Updates strings based on comments
llchrisll Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Tools/msgstringtable/msgstringtable_decoded.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2976,8 +2976,8 @@ MSI_SUCCESS,"Success"
MSI_RESET,"Return"
MSI_MANUFACTURED_MARRIAGERING_ITEM,"With Mr/Miss"
MSI_CHANGE_HOMUN_NAME,"The Homunculus's name will be changed to^0000ff^0000ff %s^000000^000000, Are you sure?"
MSI_BLOCK_CALL_PERMIT,"Call function is ON"
MSI_BLOCK_CALL_REJECT,"Call function is OFF"
MSI_BLOCK_CALL_PERMIT,"You can be \"Called\" with various skills (Emergency Call,...). (/call)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'd go with "Player recalling skills is disabled/enabled" same for the bottom related call messages.

Copy link
Owner Author

@llchrisll llchrisll Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s fine this way, as it’s only affecting the player not the skills in general.

MSI_BLOCK_CALL_REJECT,"You cannot be \"Called\" with various skills (Emergency Call,...). (/call)"
MSI_BLOCK_CALL_NOTIFY,"Display Call messages"
MSI_RESULT_FAIL_ASSISTANT,"This character is currently opening a shop and can't be deleted"
MSI_USESKILL_FAIL_EXIST_STORE_ASSISTANT,"The same vend shop NPC has been set up"
Expand Down Expand Up @@ -3543,7 +3543,7 @@ MSI_ITEMSTORE_NOW_LOADING,"NOW LOADING..."
MSI_RODEX_BUTTON_DELETE,"Delete"
MSI_RODEX_BUTTON_ANSWER,"Reply"
MSI_RODEX_BUTTON_SEND,"Send"
MSI_RODEX_BUTTON_CONFIRM_ID,"Validate name"
MSI_RODEX_BUTTON_CONFIRM_ID,"Check Name"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with a simple, "Verify" or just keep it "Validate" since the error messages will tell you what's wrong anyways.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah would also work

MSI_RODEX_TAB_ADMIN,"Notice"
MSI_RODEX_TAB_DEFAULT,"General"
MSI_RODEX_TAB_RETURN,"Return"
Expand Down
5 changes: 3 additions & 2 deletions Translation/Renewal/data/luafiles514/lua files/datainfo/helpmsgstr.lub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
-- Continuated by llchrisll at https://github.com/llchrisll/ROenglishRE
-- This file can be distributed, used and modified freely
-- This file shouldn't be claimed as part of your project, unless you fork it from https://github.com/llchrisll/ROenglishRE
-- Last updated: 20230321
-- Last updated: 20241005

HelpMsgStr = {
"/tip : Opens \"Tip of the Day\" window",
Expand Down Expand Up @@ -82,5 +82,6 @@ HelpMsgStr = {
"$$lv20~30 : Monster of that level range are displayed (Amount may vary).",
"/return: Disables event clothes such as Wedding and Santa Costumes.",
"/zoom: Turn Zoom Out On/Off.",
"/showshop: Displays all stalls on screen. On/Off"
"/showshop: Displays all stalls on screen. On/Off",
"/call : Allows/Prevents being called by Calling skills. On/Off"
}
6 changes: 3 additions & 3 deletions Translation/Renewal/data/luafiles514/lua files/msgstring_kr.lub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
-- Continuated by llchrisll at https://github.com/llchrisll/ROenglishRE
-- This file can be distributed, used and modified freely
-- This file shouldn't be claimed as part of your project, unless you fork it from https://github.com/llchrisll/ROenglishRE
-- Last updated: 20240918
-- Last updated: 20241005

MsgStrID = {
MSI_HK_SKILLBAR1_1 = "Hotkey 1-1",
Expand Down Expand Up @@ -197,11 +197,11 @@ MsgStrID = {
MSI_QUAKE_EFFECT_ONOFF = "/quake : Flicker effect On/Off",
MSI_SPRITEMABLE_ONOFF = "/mable : Display Spirit Marble On/Off",
MSI_EXPAND_SIGHT = "/zoom : Turns Zoom Out option On/Off",
MSI_CALL_COMMAND_ONOFF = "/call : Call Function On Off",
MSI_CALL_COMMAND_ONOFF = "/call : Allows/Prevents being called by Calling skills. On/Off",
MSI_HI = "/hi or /hi message: Send greetings to people who are online and registered on your Friend List.",
MSI_BLACKSMITH = "/blacksmith : Shows the top 10 Blacksmiths in the server.",
MSI_ALCHEMIST = "/alchemist : Shows the top 10 Alchemists in the server.",
MSI_HELP = "/h or /help : Shows this Command Help List",
MSI_HELP = "/h : Shows this Command Help List",
MSI_WHO = "/w or /who : Shows the current number of online players.",
MSI_SIT = "/sit : Sit command. If you are sitting, you will stand instead.",
MSI_STAND = "/stand : Stand command. If you are standing, you will sit instead.",
Expand Down
4 changes: 2 additions & 2 deletions Translation/Renewal/data/luafiles514/lua files/msgstring_kr_s.lub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
-- Continuated by llchrisll at https://github.com/llchrisll/ROenglishRE
-- This file can be distributed, used and modified freely
-- This file shouldn't be claimed as part of your project, unless you fork it from https://github.com/llchrisll/ROenglishRE
-- Last updated: 20240918
-- Last updated: 20241005

MsgStrID = {
MSI_HK_SKILLBAR1_1 = "Hotkey 1-1",
Expand Down Expand Up @@ -197,7 +197,7 @@ MsgStrID = {
MSI_QUAKE_EFFECT_ONOFF = "/quake : Flicker effect On/Off",
MSI_SPRITEMABLE_ONOFF = "/mable : Display Spirit Marble On/Off",
MSI_EXPAND_SIGHT = "/zoom : Turns Zoom Out option On/Off",
MSI_CALL_COMMAND_ONOFF = "/call : Call Function On Off",
MSI_CALL_COMMAND_ONOFF = "/call : Allows/Prevents being called by Calling skills. On/Off",
MSI_HI = "/hi or /hi message: Send greetings to people who are online and registered on your Friend List.",
MSI_BLACKSMITH = "/blacksmith : Shows the top 10 Blacksmiths in the server.",
MSI_ALCHEMIST = "/alchemist : Shows the top 10 Alchemists in the server.",
Expand Down
6 changes: 3 additions & 3 deletions Translation/Renewal/data/msgstringtable.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2976,8 +2976,8 @@ Success#
Return#
With Mr/Miss#
The Homunculus's name will be changed to^0000ff^0000ff %s^000000^000000, Are you sure?#
Call function is ON#
Call function is OFF#
You can be called by Calling Skills (Emergency Call,...). (/call)#
You cannot be called by Calling Skills (Emergency Call,...). (/call)#
Display Call messages#
This character is currently opening a shop and can't be deleted#
The same vend shop NPC has been set up#
Expand Down Expand Up @@ -3543,7 +3543,7 @@ NOW LOADING..#
Delete#
Reply#
Send#
Validate name#
Check Name#
Notice#
General#
Return#
Expand Down