fixup! [FIRRTL] Parse Layer-Associated Probes

llvm · Jan 12, 2024 · dea1a8e · dea1a8e
1 parent df24717
commit dea1a8e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/Dialect/FIRRTL/Import/FIRParser.cpp b/lib/Dialect/FIRRTL/Import/FIRParser.cpp
@@ -942,14 +942,16 @@ ParseResult FIRParser::parseType(FIRRTLType &result, const Twine &message) {
       return failure();
     while (getToken().getKind() == FIRToken::identifier) {
       StringRef layer;
-      if (parseId(layer, "expected layer name"))
-        return failure();
+      loc = getToken().getLoc();
+      (void)parseId(layer, "expected layer name");
       layers.push_back(layer);
       if (getToken().getKind() == FIRToken::period)
         consumeToken();
     }
-    if (parseToken(FIRToken::greater, "expected '>' in reference type"))
+    if (!consumeIf(FIRToken::greater)) {
+      emitError(loc, "expected '>' to end reference type");
       return failure();
+    }
 
     bool forceable = kind == FIRToken::kw_RWProbe;
 

diff --git a/test/Dialect/FIRRTL/parse-errors.fir b/test/Dialect/FIRRTL/parse-errors.fir
@@ -1246,3 +1246,11 @@ circuit Foo:
   option Platform:
     FPGA
     FPGA
+
+;// -----
+FIRRTL version 4.0.0
+circuit Foo:
+  layer A bind:
+  module Foo:
+    ; expected-error @below {{expected '>' to end reference type}}
+    output a: Probe<UInt<1>