[FIRRTL] Error if asked to add a port to a public module. #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
force-pushed
the
feature/no-bore-public
branch
from
a9e3687
to
8306e17
Compare
seldridge
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LGTM
This needs to update the C-API for Firtool.h. After that is fixed, this is good to land.
CC: @sequencer as this likely affects bindings.
Add option to allow this for compatibility. Add statistic to count ports added to public modules, as an interesting bit of information but particularly to track how many are still being added when updating a code base to avoid this.
dtzSiFive
force-pushed
the
feature/no-bore-public
branch
from
8306e17
to
ebbc645
Compare
rwy7
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to allow this for compatibility.
Add statistic to count ports added to public modules, as an interesting bit of information but particularly to track how many are still being added when updating a code base to avoid this.