[firtool] fix: check uninferred resets after removing unused modules #7380
+126
−29
Commits on Aug 10, 2024
-
[firtool] fix: check uninferred resets after removing unused modules
The Chisel's Definition API generates modules that are not instantiated, whose reset cannot be inferred properly. Check the uninferred resets after removing unreferenced modules to resolve it. Signed-off-by: unlsycn <unlsycn@unlsycn.com>
Commits on Aug 11, 2024
-
fix: remove redundant function declaration
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
-
refactor: nest CheckUninferredResets on FModuleLike
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
-
test: add a test to verify legal uninferred reset
Signed-off-by: unlsycn <unlsycn@unlsycn.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.