[Arc] Make the canonicalizer shuffle the input vector elements before merging #7394
Conversation
elhewaty
force-pushed
the
add-optimization-to-canonicalizer
branch
from
4c6e9cf
to
c1a1f0d
Compare
| if (tempVec != SmallVector<Value>(otherVecOp.getResults().begin(), | ||
| otherVecOp.getResults().end())) { |
There was a problem hiding this comment.
Does tempVec != otherVecOp.getResults() not work here?
There was a problem hiding this comment.
I will try, but I think getResults() returns result_range which cannot be converted into a SmallVector<Value> but is worth trying!
There was a problem hiding this comment.
There should be an implicit conversion from SmallVector<Value> to an iterator range, which should theoretically be able to compare against a result range. Worth trying, don't worry if it doesn't work 😃
There was a problem hiding this comment.
I didn't work!
error: invalid operands to binary expression ('SmallVector<mlir::Value>' and '::mlir::Operation::result_range' (aka 'mlir::ResultRange'))
if (tempVec != otherVecOp.getResults())
There was a problem hiding this comment.
Thanks for checking 😃
There was a problem hiding this comment.
@fabianschuiki, should I land this now?
There was a problem hiding this comment.
It's 12:17 AM here, so please land it if it's Okay.
The canonicalizer crashes 😢, I will test it before pushing but I need to reduce the test case. |
elhewaty
force-pushed
the
add-optimization-to-canonicalizer
branch
from
c1a1f0d
to
7818e2b
Compare
It works on the dual rocket core |
No description provided.