Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add CheckRecursiveInstantiation diagnostic pass #7433

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[FIRRTL] Add CheckRecursiveInstantiation diagnostic pass #7433

merged 3 commits into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. [FIRRTL] Remove module self-instantiation verifier 

    This removes a verifier that checks that modules do not instantiate
themsselves.  This will be covered by a new diagnostic pass which can
handle indirect recursion as well.  This instance verifier goes a bit
beyond what we normally check in verifiers, as it must reach upward to
find the owning module to compare against its target module, and we
normally try to check only local operation properties in verifiers.
    @youngar
    youngar committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    0525421 View commit details
    Browse the repository at this point in the history

  2. [FIRRTL] Add CheckRecursiveInstantiation diagnostic pass 

    This adds a pass to FIRRTL to check for recursive module instantiation,
which is illegal because it corresponds to infinitely sized hardware.
    @youngar
    youngar committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    1a8302d View commit details
    Browse the repository at this point in the history

  3. [firtool] run CheckRecursiveInstantiation pass

    @youngar
    youngar committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9e3828f View commit details
    Browse the repository at this point in the history