Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESI][Runtime] Poll method and optional service thread polling #7460

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[ESI][Runtime] Poll method and optional service thread polling #7460

merged 2 commits into from
Aug 8, 2024

Commits on Aug 8, 2024

  1. [ESI][Runtime] Poll method and optional service thread polling 

    Add a poll method to ports, a master poll method to the Accelerator, and
the ability to poll from the service thread. Also, only spin up the
service thread if it's requested.

The service thread polling (in particular) required some ownership
changes: Accelerator objects now belong to the AcceleratorConnection so
that the ports aren't destructed before the service thread gets shutdown
(which causes an invalid memory access). This particular binding isn't
ideal, is brittle, and will be an issue for anything doing the polling.
Resolving #7457 should mitigate this issue.

Backends are now _required_ to call `disconnect` in their destructor.
    @teqdruid
    teqdruid committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1cec4b6 View commit details
    Browse the repository at this point in the history

  2. feedback

    @teqdruid
    teqdruid committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bf313f1 View commit details
    Browse the repository at this point in the history