[FIRRTL] Add list concatenation operation. #7486
Conversation
This operation produces a list by concatenating lists of the same type. The operation definition and a simple round trip test have been added. This is used to compose lists, which is a key feature to enable hierarchical composition of Properties.
| let arguments = (ins Variadic<ListType>:$subLists); | ||
| let results = (outs ListType:$result); | ||
|
|
||
| let assemblyFormat = "$subLists attr-dict `:` type($result)"; |
There was a problem hiding this comment.
Might be neat to give this a folder in the future for IR simplification (and use w/IMCP) but that can come later.
There was a problem hiding this comment.
Could be interesting! I think there are lot of interesting optimizations we could explore on properties.
There was a problem hiding this comment.
Yeah just thinking about cleaning up the trivial stuff that literally constant-folds. I'm not sure we're likely to feed this constants at first/soon and yep lots of interesting things for sure! Look forward to it, LMK if want some assistance!
Looks like integer ops have issues filed for adding folders there, but quick check on some internal usage suggests these wouldn't help much just yet anyway.
Anyway stray thought, GLHF!
This operation produces a list by concatenating lists of the same
type. The operation definition and a simple round trip test have been
added. This is used to compose lists, which is a key feature to enable
hierarchical composition of Properties.