[ESI][Manifest] Embed constants in manifest #7489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users want to know what constants were used in a design. Plumb them through using the manifest. No runtime support, no pycde support. Cleanups to the manifest as well. Update the runtime to support the schema changes to the manifest.
teqdruid
force-pushed
the
teqdruid/esi/constants
branch
from
04d16e8
to
ac0fef9
Compare
mortbopet
approved these changes
Aug 12, 2024
| } | ||
|
|
||
| // Now, emit a JSON object for each symbol. | ||
| for (const auto &symNameInfo : symbolInfoLookup) { |
There was a problem hiding this comment.
Ideally, some sort of human-readable documentation would also have been modified with this change to the manifest builder (in other words, where is the manifest spec?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users want to know what constants were used in a design. Plumb them through using the manifest. No runtime support, no pycde support.
Cleanups to the manifest as well. Update the runtime to support the schema changes to the manifest.