Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firtool] Change layer specialization CLI interface #7520

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

youngar
Copy link
Member

@youngar youngar commented Aug 15, 2024

This changes how nested layers are specified when using --enable-layers or --disable-layers. Previously a nested layer was specified with A::B, but not it follows the syntax in the FIRRTL spec for layers, which is A.B.

This changes how nested layers are specified when using --enable-layers
or --disable-layers.  Previously a nested layer was specified with
`A::B`, but not it follows the syntax in the FIRRTL spec for layers,
which is `A.B`.
@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Aug 15, 2024
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Fixes #7418 , right?

@youngar youngar linked an issue Aug 15, 2024 that may be closed by this pull request
@youngar youngar merged commit 6aa8715 into llvm:main Aug 15, 2024
4 checks passed
@youngar youngar deleted the firrtl-layer-cli-fix branch August 15, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firtool] use FIRRTL layer syntax for specialization CL options
3 participants