-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MooreToCore] Add always_comb and always_latch lowering support #7532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 😲! So nice 🚀!
6bc9822
to
c2f747a
Compare
c2f747a
to
9598677
Compare
@@ -1388,6 +1389,9 @@ void MooreToCorePass::runOnOperation() { | |||
MLIRContext &context = getContext(); | |||
ModuleOp module = getOperation(); | |||
|
|||
IRRewriter rewriter(module); | |||
(void)mlir::eraseUnreachableBlocks(rewriter, module->getRegions()); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🥳
use_empty
is not up-to-date when erasing blocks with the rewriter as it only marks them as replaced.func.func
always_comb
andalways_latch
procedures