Advanced LayerSink #7548
Open
Advanced LayerSink #7548
+1,250
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
force-pushed
the
advanced-layer-sink
branch
3 times, most recently
from
5464ac7
to
5031be0
Compare
rwy7
commented
Sep 18, 2024
lib/Firtool/Firtool.cpp
Outdated
| // implementation assumes it can run at a time where every register is | ||
| // currently in the final module it will be emitted in, all registers have | ||
| // been created, and no registers have yet been removed. | ||
| if (opt.isRandomEnabled(FirtoolOptions::RandomKind::Reg)) |
There was a problem hiding this comment.
Moving register randomization to before layerSink, which, as an optimization, can delete registers.
rwy7
commented
Sep 18, 2024
| @@ -1,5 +1,5 @@ | |||
| // RUN: circt-opt %s -split-input-file | circt-opt -split-input-file | |||
| // RUN: firtool %s -split-input-file | |||
| // RUN: firtool %s -preserve-values=named -split-input-file | |||
There was a problem hiding this comment.
Using interesting_name and preserve-values=named together to prevent layer-sink from deleting instances or wires that are necessary for the test.
rwy7
force-pushed
the
advanced-layer-sink
branch
4 times, most recently
from
ef5e5c2
to
82c3e10
Compare
rwy7
force-pushed
the
advanced-layer-sink
branch
2 times, most recently
from
371c340
to
d22c585
Compare
rwy7
force-pushed
the
advanced-layer-sink
branch
from
5b5a10e
to
f81954a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add advanced layer sink, a new FIRRTL-dialect transform pass. Advanced layer sink serves the same purpose as the original layer sink pass: move ops into layers if their uses permits it. Advanced layer sink works by finding the shallowest block a value is used by an effectful op, and then sinking the defining op to that block. Compared to the original layer sink pass, which only relied on dominance info, this pass can sink cyclical structures, such as registers.