Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Improve Layer Merge Performance #7552

Merged
merged 2 commits into from
Aug 24, 2024
Merged

[FIRRTL] Improve Layer Merge Performance #7552

merged 2 commits into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. [FIRRTL] Improve Layer Merge Performance 

    Fix a performance issue in the `LayerMerge` pass.  Apparently, repeated
use of `inlineBlockBefore` with a forward walk can be a performance issue.
Fix this, by reversing the iteration order.

h/t @youngar for algorithmic suggestions.

Fixes #7551.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
    @seldridge
    seldridge committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    d5bf8f8 View commit details
    Browse the repository at this point in the history

  2. [FIRRTL] Cleanup variable names in LayerMerge, NFC 

    Superficial cleanup of LayerMerge to make the variable names make more
sense.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
    @seldridge
    seldridge committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    66122eb View commit details
    Browse the repository at this point in the history