[ExtractInstances] Add the extract instances metadata to OM Classes #7667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
mikeurbach
and removed request for
seldridge and
darthscsi
uenoku
reviewed
Oct 5, 2024
uenoku
reviewed
Oct 5, 2024
prithayan
force-pushed
the
dev/pbarua/extract-instances-metadata
branch
from
1b83ab2
to
9dc5943
Compare
mikeurbach
reviewed
Oct 7, 2024
prithayan
force-pushed
the
dev/pbarua/extract-instances-metadata
branch
from
9dc5943
to
fca36c1
Compare
prithayan
force-pushed
the
dev/pbarua/extract-instances-metadata
branch
from
395be6e
to
568c7fc
Compare
|
@mikeurbach , @uenoku, this PR is ready for another round of review, please take a look. |
uenoku
reviewed
Oct 10, 2024
Comment on lines
364
to
369
| // This builds a ClassOp, with the specified fieldNames and fieldTypes as | ||
| // ports. The output property is set from the input property port. | ||
| ClassOp static buildSimpleClassOp( | ||
| mlir::OpBuilder &odsBuilder, mlir::Location loc, mlir::Twine name, | ||
| mlir::ArrayRef<mlir::StringRef> fieldNames, | ||
| mlir::ArrayRef<mlir::Type> fieldTypes); |
There was a problem hiding this comment.
Can it be moved to the section let builders = [..]?
mikeurbach
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
ExtractInstancesmetadata to the OM classes. The OM dialect can then be parsed to generate the respective metadata files.This change enables to move all the metadata to the OM dialect, instead of existing as verbatim ops.