Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][ProbesToSignals] RWProbe support #7706

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[FIRRTL][ProbesToSignals] RWProbe support #7706

merged 1 commit into from
Oct 15, 2024

Conversation

dtzSiFive
Copy link
Contributor

  • Define type conversion mapping rwprobe -> passive(T)
  • Forceable support (passive read of data result)
  • RWProbeOp support (materialize target, to passive)
  • Reject {force,release}{,_initial}

Add some basic tests.

@dtzSiFive
[FIRRTL][ProbesToSignals] RWProbe support
7caedca 
* Define type conversion mapping rwprobe<T> -> passive(T)
* Forceable support (passive read of data result)
* RWProbeOp support (materialize target, to passive)
* Reject {force,release}{,_initial}

Add some basic tests.
@dtzSiFive dtzSiFive added enhancement New feature or request FIRRTL Involving the `firrtl` dialect labels Oct 14, 2024
prithayan
prithayan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the RWProbe support, LGTM.

@dtzSiFive dtzSiFive merged commit 5a6a561 into llvm:main Oct 15, 2024
4 checks passed
@dtzSiFive dtzSiFive deleted the feature/rwprobe-probestosignals branch October 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prithayan prithayan prithayan approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

@youngar youngar Awaiting requested review from youngar

Assignees
No one assigned
Labels
enhancement New feature or request FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @prithayan