Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExternalizeRegisters][NFC] Clean up initial value fetching #7843

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Nov 19, 2024

Just a cleanup commit that reuses unwrapImmutableValue instead of pretty much reimplementing it as I only just found out it existed - thanks for including this @uenoku!

Copy link
Member

@maerhart maerhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool improvement. Thanks!

lib/Tools/circt-bmc/ExternalizeRegisters.cpp Outdated Show resolved Hide resolved
@TaoBi22 TaoBi22 merged commit 49a8ec4 into llvm:main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants